RFC: Introduce a STM32 SYSCFG interrupt controller driver #57310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurel32
requested review from
dcpleung,
erwango,
nashif and
sambhurst
as code owners
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
ABOSTM,
FRASTM,
GeorgeCGV,
galak,
gautierg-st and
keith-zephyr
This commit tries to solve the problem of the shared interrupt on the STM32G0 line of MCUs (and probably other lines) by adding an interrupt muxer for lines that are shared by multiple devices, leveraging the existing multilevel interrupts framework. It uses flag pending interrupts from each interrupt line available in the SYSCFG controller to correctly route the interrupts to the correct device, and correctly enable or disable the shared interrupt depending on the state of each individual interrupt. Signed-off-by: Aurelien Jarno <[email protected]>
Enable the shared interrupt muxer for the i2c2/3 and spi2/3 devices in the device tree, and configure the multilevel interrupt framework accordingly. Signed-off-by: Aurelien Jarno <[email protected]>
Enable the shared interrupt muxer for ucpd1/2 devices on stm32g071/81 and ucpd1/ucpd2/usb devices on stm32g0b1/c1 in the device tree, and configure the multilevel interrupt framework accordingly. For that to the interrupt sharing support in the UCPD driver needs to be removed as the instances won't see the interrupt of each other anymore. Signed-off-by: Aurelien Jarno <[email protected]>
Contributor
Author
This part actually doesn't work. While the multilevel interrupt framework correctly intercept the calls to |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve the problem of the shared interrupt on the STM32G0 line of MCUs (and probably other Cortex-M0 based lines) by adding an interrupt muxer for lines that are shared by multiple devices, by leveraging the existing multilevel interrupts framework.
It uses flag pending interrupts from each interrupt line available in the SYSCFG controller to correctly route the interrupts to the correct device, and correctly enable or disable the shared interrupt depending on the state of each individual interrupt.
The last two patch enables the shared interrupt on i2c, spi and ucpd and usb devices.
It is an alternative to #57146 (at least for STM32), which has some advantages over it:
It also has some drawbacks: