Skip to content

drivers: counter: Add support for rpi_pico timer #57134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 13, 2023
Merged

drivers: counter: Add support for rpi_pico timer #57134

merged 6 commits into from
Sep 13, 2023

Conversation

@soburi
Copy link
Member

@soburi soburi commented Apr 21, 2023 •
edited
Loading

Adds support for rpi_pico timer

Signed-off-by: TOKITA Hiroshi [email protected]

This PR need to modify HAL changes zephyrproject-rtos/hal_rpi_pico#5.

@zephyrbot zephyrbot added manifest manifest-hal_rpi_pico DNM This PR should not be merged (Do Not Merge) labels Apr 21, 2023
@zephyrbot
Copy link

zephyrbot commented Apr 21, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_rpi_pico zephyrproject-rtos/hal_rpi_pico@b7801e4 zephyrproject-rtos/hal_rpi_pico@fba7162 (zephyr) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

This was referenced Apr 21, 2023
Open
Merged
@soburi soburi force-pushed the pico_timer branch 2 times, most recently from fc099ac to 5dd310d Compare April 21, 2023 22:58
@soburi soburi changed the title drivers: counter: add support for rpi_pico timer drivers: counter: Add support for rpi_pico timer Apr 21, 2023
@soburi soburi marked this pull request as ready for review April 21, 2023 22:58
@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) area: Counter labels Apr 21, 2023
@zephyrbot zephyrbot requested a review from galak April 21, 2023 22:59
@soburi soburi force-pushed the pico_timer branch 2 times, most recently from d7e5436 to 7d67d09 Compare April 26, 2023 17:01
@yonsch
Copy link
Contributor

yonsch commented May 30, 2023 •
edited by soburi
Loading

Is the patch to the SDK necessary, or can the relevant function just be implemented in Zephyr to fit our needs?

@soburi
Copy link
Member Author

soburi commented May 30, 2023

@yonsch

Is the patch to the SDK necessary, or can the relevant function just be implemented in Zephyr to fit our needs?

As a basic policy, I would like to use Pico-SDK.
However, Pico-SDK has an IRQ vector table that it own, which conflicts with Zephyr's implementation.
Due to this issue, the Pico-SDK cannot be used without modification.
So I have removed the IRQ vector table manipulation from the Pico-SDK and changed the interface slightly to fit with Zephyr.
From another point of view, it can be said that the negative impact is small because it cannot be used in the first place without modification.

@soburi soburi force-pushed the pico_timer branch 2 times, most recently from 64ce4a6 to b5fe18a Compare July 30, 2023 01:20
nordic-krch
nordic-krch reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@nordic-krch nordic-krch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok. one minor finding.

drivers/counter/counter_rpi_pico_timer.c Outdated
Copy link
Contributor

@nordic-krch nordic-krch Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing static

Copy link
Member Author

@soburi soburi Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing out.
Fixed it.

@soburi soburi requested a review from nordic-krch July 31, 2023 12:00
@cfriedt
Copy link
Member

cfriedt commented Aug 3, 2023

dev-review: Created assignee / reviewers for zephyrproject-rtos/hal_rpi_pico#5 which this was blocked on

@soburi
Copy link
Member Author

soburi commented Aug 31, 2023

@yonsch
Could you take a look please?

yonsch
yonsch previously approved these changes Sep 1, 2023
View reviewed changes
@soburi
manifest: Update hal_rpi_pico module
916ba27 
Update hal_rpi_pico to commit fba7162c to introduce
the hardware_timer modification.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
modules: hal_rpi_pico: Enable TIMER driver
dc576c3 
Enable TIME driver.
Add the path of the TIME driver header into include paths.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
drivers: counter: Add support for rpi_pico timer
af65076 
Adds support for rpi_pico timer

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
boards: rpi_pico: Add timer support
b40f335 
Add timer support for the rpi_pico board

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
samples: drivers: counter: alarm: Add support for rpi_pico
1618e4e 
Add the rpi_pico board to the supported boards for the counter
alarm sample

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
tests: counter: counter_basic_api: Add support for rpi_pico boards
402bf02 
Add support for rpi_pico board.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Sep 1, 2023
@soburi soburi requested a review from yonsch September 1, 2023 15:15
@soburi
Copy link
Member Author

soburi commented Sep 1, 2023

@nordic-krch
Could you take a look please?

@carlescufi carlescufi merged commit 5119af0 into zephyrproject-rtos:main Sep 13, 2023
@soburi soburi deleted the pico_timer branch September 13, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlescufi carlescufi carlescufi approved these changes

@yonsch yonsch yonsch approved these changes

@nashif nashif Awaiting requested review from nashif

@galak galak Awaiting requested review from galak

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

Assignees

@yonsch yonsch

Labels

area: Counter area: Devicetree Binding PR modifies or adds a Device Tree binding manifest manifest-hal_rpi_pico platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico)

Projects

Dev Review
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@soburi @zephyrbot @yonsch @cfriedt @carlescufi @nordic-krch