docs/build-flash-debug: expand one-time CMake arguments section #56671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change "re-run CMake" to "re-run CMake configuration steps" because `west build -v ...` displays `cmake --build ...` every time which can confuse non-experts. - Explain what is the actual issue with re-configuring: it makes the incremental builds slower. But not much slower: ``` $ west build -b qemu_x86 samples/hello_world/ -DCONFIG_OUTPUT_STAT=y [133/133] Linking C executable zephyr/zephyr.elf $ west build -b qemu_x86 samples/hello_world/ -DCONFIG_OUTPUT_STAT=y [16/16] Linking C executable zephyr/zephyr.elf ``` - Explain that the best solution is to simply skip to the next section Signed-off-by: Marc Herbert <[email protected]>
zephyrbot
requested review from
carlescufi,
kartben,
mbolivar-nordic and
swinslow
This was referenced Apr 8, 2023
tejlmand
approved these changes
Apr 11, 2023
dcpleung
approved these changes
Apr 11, 2023
nashif
approved these changes
Apr 12, 2023
carlescufi
approved these changes
Apr 12, 2023
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Apr 12, 2023
--cmake-args is actually safe, just a bit slower. See explanation in zephyrproject-rtos/zephyr#56671 Fixes unnecessary restriction added by commit 9fb7a60 ("xtensa-build-zephyr.py: fix -C option so it can support whitespace") Also warn for overlays because they act the same. Log the `west config` due to the suggestion to use build.cmake-args and the recent rimage changes in Zephyr PR 54700 Signed-off-by: Marc Herbert <[email protected]>
kv2019i
pushed a commit
to thesofproject/sof
that referenced
this pull request
Apr 24, 2023
--cmake-args is actually safe, just a bit slower. See explanation in zephyrproject-rtos/zephyr#56671 Fixes unnecessary restriction added by commit 9fb7a60 ("xtensa-build-zephyr.py: fix -C option so it can support whitespace") Also warn for overlays because they act the same. Log the `west config` due to the suggestion to use build.cmake-args and the recent rimage changes in Zephyr PR 54700 Signed-off-by: Marc Herbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change "re-run CMake" to "re-run CMake configuration steps" because
west build -v ...displayscmake --build ...every time which can confuse non-experts.Explain what is the actual issue with re-configuring: it makes the incremental builds slower. But not much slower:
EDIT: this was found in bug
It was previously discussed (and misunderstood) in: