Skip to content

Conversation

@cfriedt
Copy link
Member

@cfriedt cfriedt commented Apr 1, 2023

The logic in this test only worked for a subset of configurations with 64-bit counters. Remove the test to ensure the suite passes on all platforms.

Fixes #53605

@cfriedt cfriedt marked this pull request as ready for review April 1, 2023 13:14
@zephyrbot zephyrbot added the area: POSIX POSIX API Library label Apr 1, 2023
@cfriedt
Copy link
Member Author

cfriedt commented Apr 1, 2023

cc @nordic-piks

@evgeniy-paltsev
Copy link
Contributor

The logic in this test only worked for a subset of configurations with 64-bit counters. Remove the test to ensure the suite passes on all platforms.

Just wondering why it's not enough to skip this test on the platform with non-64-bit counters? Like if CONFIG_TIMER_HAS_64BIT_CYCLE_COUNTER isn't set?

@cfriedt
Copy link
Member Author

cfriedt commented Apr 1, 2023

The logic in this test only worked for a subset of configurations with 64-bit counters. Remove the test to ensure the suite passes on all platforms.

Just wondering why it's not enough to skip this test on the platform with non-64-bit counters? Like if CONFIG_TIMER_HAS_64BIT_CYCLE_COUNTER isn't set?

That probably would work (at least for a subset of boards with 64-bit counters) but it would also be nice if there were some API / config consistency among systems with < 64-bit counters.

Currently, it's "this clock rolls over sometime after 365 days, maybe", which is a bit slippery.

I'd rather not codify a test here if we are missing some critical pieces of info and left guessing about them due to lack of abstraction.

However, I would be perfectly happy to review another PR on this subject if that were to appear.

@carlescufi carlescufi merged commit 9bde7ec into zephyrproject-rtos:main Apr 4, 2023
@cfriedt cfriedt deleted the issues/53605/tests-posix-common-portability-posix-common-fails-posix-apis-test-clock-gettime-rollover branch June 3, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: POSIX POSIX API Library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: posix: common: portability.posix.common fails - posix_apis.test_clock_gettime_rollover

5 participants