V2.7 branch timing related fixes #55192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: API
cfriedt
force-pushed
the
v2.7-branch-timing-related-fixes
branch
from
d16e310 to
6392b2e
Compare
cfriedt
requested review from
MaureenHelm,
andyross,
carlescufi,
dcpleung,
galak,
nashif and
pfalcon
as code owners
Member
Author
|
I'm unable to reproduce this locally in |
Member
Author
|
Also, it looks as though the Backport Issue Check is a false negative - if you click through to the actual check, it seems to have passed, but the status was not updated in the PR. CC @stephanosio |
dkalowsk
approved these changes
Apr 5, 2023
Contributor
dkalowsk
left a comment
dkalowsk
left a comment
There was a problem hiding this comment.
Pulled and test booted locally, seems to work correctly on our products
nashif
approved these changes
Apr 6, 2023
The header can't be fully used in standalone mode: toolchain.h has to be included first, otherwise the ALWAYS_INLINE attribute is not defined. Headers that can be directly included and are not self-contained should be considered a bad practice. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Algorithm was converting uptime to nanoseconds which can easily lead to overflows. Changed algorithm to use milliseconds and nanoseconds for remainder only. Signed-off-by: Krzysztof Chruscinski <[email protected]>
Prior to zephyrproject-rtos#41602, due to the ordering of operations (first mul, then div), an intermediate value would overflow, resulting in a time non-linearity. This test ensures that time rolls-over properly. Signed-off-by: Chris Friedt <[email protected]> (cherry picked from commit 74c9c0e)
Add maximum timeout used for conversion to Kconfig. Option is used to determine which conversion algorithm to use: faster but overflowing earlier or slower without early overflow. Signed-off-by: Krzysztof Chruscinski <[email protected]> (cherry picked from commit 50c7c7b)
The previous method used to calculate seconds in `clock_gettime()` seemed to have an inaccuracy that grew with time causing the seconds to be off by an order of magnitude when ticks would roll over. This change fixes the method used to calculate seconds. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
v2.7-branch-timing-related-fixes
branch
from
6392b2e to
b952a07
Compare
Member
Author
|
It looks like there was an update by Stephanos to fix some CI issues, which mitigated the Minor adjustments were required to get
#include <sys/time_units.h>
#include <ztest.h>to #include <ztest.h>
#include <sys/time_units.h> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in changes from several related backports
#52867
#53183
#52832
Fixes #41111
Related #53605
To address the issue above, we have dropped commit 662f37d (consistent with
main).