drivers: regulator: add support for RaspberryPi Pico regulator. #54456

soburi · 2023-02-04T14:22:02Z

add support for rpi_pico regulator.

Signed-off-by: TOKITA Hiroshi [email protected]

Since the RaspberryPi Pico does not expose the output wiring of the Core Supply Regulator, I scraped the back of the board as shown in the picture, connected it to the ADC, and run the 'tests/drivers/regulator/voltage/' test.

In RaspberryPi Pico, the Core voltage is supplied from the Core Supply Regulator, and if you disable the Core Supply Regulator or set the output to Hi-Z, the MCU will stop.
To fully test the behavior would have required designing a special board to supply the core voltage externally. So which is not tested.
From this reason, made the default settings prevent running it.

danieldegrasse · 2023-02-04T17:22:40Z

drivers/regulator/Kconfig.rpi_pico

The description and help string of this Kconfig need to be updated

Thank you for reviewing.
I updated the description.

danieldegrasse · 2023-02-04T17:26:07Z

drivers/regulator/Kconfig.rpi_pico

Description and help string need to be updated, unless the RPI is using an NXP regulator (from the datasheet, this seems to be an internal regulator)

Oops, this is embarrassing...
Fixed it.

danieldegrasse · 2023-02-04T17:30:36Z

drivers/regulator/regulator_rpi_pico.c

I've not familiar with this chip, but it seems to me that lower voltages could be useful if the chip was underclocked or entering a low power mode. Is there no situation where the 800000uV output would be useful?

I noticed these values are usable when externally supplying the core voltage. (RP2040 usually drives by voltage from the built-in regulator, but can configure not use the regulator.)
Thus, I changed to make all values available.
However, this does not pass the test with this board.
So I made it possible to set upper and lower test voltage limits in the test so that we could exclude unstable settings from the test.

I think this is a good solution, thank you for enabling this feature

danieldegrasse · 2023-02-04T17:34:17Z

include/zephyr/dt-bindings/regulator/rpi_pico.h

Minor nit- I would like to see a mode defined for "HI Z disabled", something like REGULATOR_RPI_PICO_MODE_RUN. Thi way, the allowed-modes and initial-mode properties don't have to simply be set to 0, and a user looking to change the regulator mode will have an easier time understanding that their options are RUN mode or HI Z mode

It's make a sense.
I added REGULATOR_RPI_PICO_MODE_NORMAL.
(I think the terminology of the RUN cause a complex situation in case if not enable regulator-boot-on property. So I chose NORMAL for it.)

danieldegrasse · 2023-02-06T03:39:38Z

drivers/regulator/regulator_rpi_pico.c

I don't have a board to test on, but won't you need to subtract VREG_VSEL_IDX_OFFSET here to get the correct voltage? As an aside, the linear range API also supports multiple values mapping to the same voltage (see here for an example: https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/regulator/regulator_pca9420.c#L127), which might be the best way to handle this regulator

Thanks for suggestion.
I rewrite with correctly linear range API usage, and removed VREG_VSEL_IDX_OFFSET.

gmarull

thanks for this change, a few questions/change requests

gmarull · 2023-02-07T09:13:03Z

dts/arm/rpi_pico/rp2040.dtsi

note: these flags are used to limit regulator operating range, not to describe hardware capabilities. So in general, they should be put at board level. Since this is put at the SoC DTS files, it looks like for example the always-on/boot-on is something that can't be configured, so driver doesn't need to implement enable/disable.

Thank you for reviewing.

I moved these properties into boards/.
And it left properties that need to prevent the regulator from turning off only.

gmarull · 2023-02-07T09:15:07Z

drivers/regulator/regulator_rpi_pico.c

note: parent device is not required, just drop it if not needed.

Delete the parent device and make a flattened structure.

gmarull · 2023-02-07T09:16:28Z

drivers/regulator/regulator_rpi_pico.c

note: it looks like you only have one regulator (CORE), so there's no need to store ranges in the instance config struct. Just use core_ranges directly.

Make it use core_ranges and num_core_ranges directly.
Removed ranges and num_ranges from struct.

gmarull · 2023-02-07T09:16:57Z

drivers/regulator/regulator_rpi_pico.c

nit: just make config->reg a vreg_and_chip_reset_hw_t * pointer

Applied it.

gmarull · 2023-02-07T09:18:27Z

tests/drivers/regulator/voltage/dts/bindings/test-regulator-voltage.yaml

volts can take int32_t range (includes negatives)

Changing default to INT32_MIN.

gmarull · 2023-02-07T09:19:04Z

tests/drivers/regulator/voltage/boards/rpi_pico.overlay

maybe add a comment on how to wire this up (seems you need to solder a wire)

I can't attach a picture here, so I described it in the comments.

Add support for rpi_pico regulator. Signed-off-by: TOKITA Hiroshi <[email protected]>

Add a regulator node to keep it always on. Signed-off-by: TOKITA Hiroshi <[email protected]>

Add min-microvolt/max-microvolt to set the range for voltages for testing. It filter out ranges that cannot test correctly in the configuration. Signed-off-by: TOKITA Hiroshi <[email protected]>

Add overlay for RaspberryPi Pico's core-supply regulator test. Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi · 2023-03-02T01:44:06Z

@danieldegrasse
Could you please re-approve this PR if there are no problems?

Add myself as codeowner of previously committed driver. - zephyrproject-rtos#54456 Signed-off-by: TOKITA Hiroshi <[email protected]>

Add myself as codeowner of previously committed driver. - #54456 Signed-off-by: TOKITA Hiroshi <[email protected]>

Add myself as codeowner of previously committed driver. - zephyrproject-rtos#54456 Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi requested review from MaureenHelm, carlescufi, galak, gmarull, nashif and yonsch as code owners February 4, 2023 14:22

zephyrbot added area: Regulators area: Devicetree Binding PR modifies or adds a Device Tree binding labels Feb 4, 2023

zephyrbot requested a review from danieldegrasse February 4, 2023 14:22

zephyrbot assigned gmarull Feb 4, 2023

soburi mentioned this pull request Feb 4, 2023

TaskList for Supporting RaspberryPi Pico peripherals #53810

Open

57 tasks

danieldegrasse reviewed Feb 4, 2023

View reviewed changes

soburi force-pushed the pico_regulator branch from 40810d2 to 5cff6a7 Compare February 5, 2023 23:40

soburi requested a review from danieldegrasse February 6, 2023 03:23

danieldegrasse reviewed Feb 6, 2023

View reviewed changes

soburi force-pushed the pico_regulator branch from 5cff6a7 to d1edf14 Compare February 6, 2023 10:00

danieldegrasse previously approved these changes Feb 6, 2023

View reviewed changes

gmarull requested changes Feb 7, 2023

View reviewed changes

gmarull reviewed Feb 7, 2023

View reviewed changes

soburi dismissed danieldegrasse’s stale review via 3524071 February 11, 2023 04:13

soburi force-pushed the pico_regulator branch from d1edf14 to 3524071 Compare February 11, 2023 04:13

zephyrbot added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Feb 11, 2023

soburi force-pushed the pico_regulator branch from 3524071 to fb14abb Compare February 11, 2023 05:13

soburi requested a review from gmarull February 11, 2023 06:43

gmarull previously approved these changes Feb 23, 2023

View reviewed changes

gmarull requested a review from danieldegrasse February 23, 2023 09:00

soburi added 3 commits February 23, 2023 20:29

drivers: regulator: add support for RaspberryPi Pico regulator.

08c06d9

Add support for rpi_pico regulator. Signed-off-by: TOKITA Hiroshi <[email protected]>

boards: arm: rpi_pico: add regulator definition on dts

ec9eeb8

Add a regulator node to keep it always on. Signed-off-by: TOKITA Hiroshi <[email protected]>

boards: arm: adafruit_kb20240: add regulator definition on dts

dd2d172

Add a regulator node to keep it always on. Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi added 3 commits February 23, 2023 20:29

boards: arm: sparkfun_pro_micro_rp2040: add regulator definition on dts

d33e2c0

Add a regulator node to keep it always on. Signed-off-by: TOKITA Hiroshi <[email protected]>

tests: drivers: regulator: voltage: add min/max voltage config

41213a2

Add min-microvolt/max-microvolt to set the range for voltages for testing. It filter out ranges that cannot test correctly in the configuration. Signed-off-by: TOKITA Hiroshi <[email protected]>

tests: drivers: regulator: voltage: add an overlay for rpi_pico

f96f6e9

Add overlay for RaspberryPi Pico's core-supply regulator test. Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi dismissed gmarull’s stale review via f96f6e9 February 23, 2023 11:40

soburi force-pushed the pico_regulator branch from fb14abb to f96f6e9 Compare February 23, 2023 11:40

soburi requested a review from gmarull February 24, 2023 14:04

gmarull approved these changes Feb 28, 2023

View reviewed changes

danieldegrasse approved these changes Mar 2, 2023

View reviewed changes

yonsch approved these changes Mar 2, 2023

View reviewed changes

carlescufi merged commit 875b0c7 into zephyrproject-rtos:main Mar 2, 2023

soburi deleted the pico_regulator branch May 28, 2023 11:51

soburi added a commit to soburi/zephyr that referenced this pull request Aug 2, 2023

CODEOWNERS: add codeowner of regulator_rpi_pico

ea5735b

Add myself as codeowner of previously committed driver. - zephyrproject-rtos#54456 Signed-off-by: TOKITA Hiroshi <[email protected]>

fabiobaltieri pushed a commit that referenced this pull request Aug 3, 2023

CODEOWNERS: add codeowner of regulator_rpi_pico

b5239cb

Add myself as codeowner of previously committed driver. - #54456 Signed-off-by: TOKITA Hiroshi <[email protected]>

kunoh pushed a commit to kunoh/zephyr that referenced this pull request Aug 7, 2023

CODEOWNERS: add codeowner of regulator_rpi_pico

10fa032

Add myself as codeowner of previously committed driver. - zephyrproject-rtos#54456 Signed-off-by: TOKITA Hiroshi <[email protected]>

drivers: regulator: add support for RaspberryPi Pico regulator. #54456

drivers: regulator: add support for RaspberryPi Pico regulator. #54456

Uh oh!

Conversation

soburi commented Feb 4, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi Feb 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi Feb 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi Feb 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi Feb 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi commented Mar 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

soburi Feb 5, 2023 •

edited

Loading

soburi Feb 11, 2023 •

edited

Loading

soburi Feb 11, 2023 •

edited

Loading

soburi Feb 11, 2023 •

edited

Loading