drivers: dma: rpi_pico: add support for RaspberryPi Pico DMA #53892

soburi · 2023-01-18T12:26:21Z

Adding RaspberryPi Pico DMA driver.

Signed-off-by: TOKITA Hiroshi [email protected]

The SPI client PR is #54195.
It pass the tests/spi/spi_loopback test.
And work fine samples/subsys/fs/fat_fs sample with my configuration.

yonsch

Thanks, a few comments/questions

modules/hal_rpi_pico/CMakeLists.txt

include/zephyr/dt-bindings/dma/rpi_pico_dma.h

yonsch · 2023-03-08T22:12:41Z

include/zephyr/drivers/dma/dma_rpi_pico.h

Why are these functions/file needed? And why is the extern needed?

It defines rpi_pico_dma specific APIs.
This is not fit in zephyr's common API features.

There is a channel_priority field in struct dma_config which could almost certainly be used for this

Thank you for reviewing, and sorry for my late response.

I recently updated the rpi_pico's HAL module. This includes the DMA priority API.
I updated this PR to call that API with refer to the channel_priority value.
The rpi_pico specific function is no needed.
I removed it.

drivers/dma/dma_rpi_pico.c

teburd · 2023-03-10T01:06:21Z

include/zephyr/drivers/dma/dma_rpi_pico.h

what is ch_cfg in this case? If we need to expand the dma_config struct to cover this, that seems more sensible that adding rpi specific functions if possible.

Since it is not necessary for basic operation, I deleted it.
For functions that may be able to common (For example, rpi_pico has a function to change the order of 2 bytes and 4 bytes), I will consider to create as a separately PR if necessary.

yonsch · 2023-03-10T10:03:19Z

Pico parts LGTM. I still think it's better to extend the DMA API rather than adding a pico specific API, as much as it's possible. But that I'll leave to @teburd to decide

Some pico-sdk drivers call a panic function, originally implemented as part of the Pico's C runtime. This commit adds a Zephyr compatible implementation of panic, so that those drivers could be compiled with Zephyr. Signed-off-by: Yonatan Schachter <[email protected]>

Enable DMA driver. Add the path of the DMA driver header into include paths. `hardware_claim` is depends by DMA driver, also enable it. Signed-off-by: TOKITA Hiroshi <[email protected]>

yonsch · 2023-03-15T11:36:47Z

~~@soburi please rebase so that the CI will test this with 1.5.0~~
Oops, you already did

teburd

Many LOG_DBG's should be LOG_ERR's

The driver, binding, and the rest look ok to me

teburd · 2023-03-15T12:54:50Z

drivers/dma/dma_rpi_pico.c

If this is a possible runtime error condition, LOG_ERR.

If this is a programming error __ASSERT()

The function caller can give the NULL as filter_pattern args.
It is need to handle as the runtime error here.

teburd · 2023-03-15T12:55:04Z

drivers/dma/dma_rpi_pico.c

teburd · 2023-03-15T12:55:18Z

drivers/dma/dma_rpi_pico.c

teburd · 2023-03-15T12:55:24Z

drivers/dma/dma_rpi_pico.c

teburd · 2023-03-15T12:56:00Z

drivers/dma/dma_rpi_pico.c

teburd · 2023-03-15T12:56:26Z

drivers/dma/dma_rpi_pico.c

All LOG_DBG's here should be LOG_ERR

Adding RaspberryPi Pico DMA driver. Signed-off-by: TOKITA Hiroshi <[email protected]>

Add overlay file for rpi_pico target. Signed-off-by: TOKITA Hiroshi <[email protected]>

Add myself as codeowner of previously committed driver. - zephyrproject-rtos#53892 Signed-off-by: TOKITA Hiroshi <[email protected]>

Add myself as codeowner of previously committed driver. - #53892 Signed-off-by: TOKITA Hiroshi <[email protected]>

Add myself as codeowner of previously committed driver. - zephyrproject-rtos#53892 Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Jan 18, 2023

teburd self-assigned this Jan 18, 2023

teburd added the area: DMA Direct Memory Access label Jan 18, 2023

soburi force-pushed the pico_dma branch 8 times, most recently from ef700a0 to 1fd9ffc Compare January 21, 2023 09:06

soburi mentioned this pull request Jan 21, 2023

TaskList for Supporting RaspberryPi Pico peripherals #53810

Open

57 tasks

soburi force-pushed the pico_dma branch 10 times, most recently from bb96b0b to ad1dfa7 Compare January 28, 2023 08:49

soburi mentioned this pull request Jan 28, 2023

drivers: spi: pl022: Add support DMA transfer #54195

Merged

soburi marked this pull request as ready for review January 28, 2023 10:32

soburi requested review from MaureenHelm, carlescufi, galak, nashif and yonsch as code owners January 28, 2023 10:32

zephyrbot added the manifest-hal_rpi_pico label Jan 28, 2023

soburi force-pushed the pico_dma branch 2 times, most recently from 9bc5bc1 to af56e30 Compare March 5, 2023 06:54

soburi requested a review from teburd March 5, 2023 08:43

yonsch requested changes Mar 8, 2023

View reviewed changes

soburi force-pushed the pico_dma branch from af56e30 to 474bd06 Compare March 9, 2023 04:24

soburi requested a review from yonsch March 9, 2023 06:26

soburi force-pushed the pico_dma branch from 474bd06 to c491194 Compare March 9, 2023 23:44

teburd requested changes Mar 10, 2023

View reviewed changes

soburi force-pushed the pico_dma branch 2 times, most recently from 9a263fb to 5a835fc Compare March 12, 2023 09:52

yonsch and others added 2 commits March 15, 2023 07:08

modules: hal_rpi_pico: Enable DMA driver

0999771

Enable DMA driver. Add the path of the DMA driver header into include paths. `hardware_claim` is depends by DMA driver, also enable it. Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi force-pushed the pico_dma branch 2 times, most recently from cc4a437 to f975dff Compare March 14, 2023 23:42

teburd requested changes Mar 15, 2023

View reviewed changes

soburi added 2 commits March 18, 2023 13:58

drivers: dma: rpi_pico: add support for RaspberryPi Pico DMA

28fc9aa

Adding RaspberryPi Pico DMA driver. Signed-off-by: TOKITA Hiroshi <[email protected]>

tests: dma: loop_transfer: add overlay for RaspberryPi Pico

3e530c6

Add overlay file for rpi_pico target. Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi force-pushed the pico_dma branch from f975dff to 3e530c6 Compare March 18, 2023 04:59

soburi requested a review from teburd March 18, 2023 05:28

yonsch approved these changes Mar 18, 2023

View reviewed changes

teburd approved these changes Mar 22, 2023

View reviewed changes

carlescufi merged commit 774affe into zephyrproject-rtos:main Mar 22, 2023

soburi deleted the pico_dma branch March 22, 2023 10:10

soburi added a commit to soburi/zephyr that referenced this pull request Aug 2, 2023

CODEOWNERS: add codeowner of dma_rpi_pico

7e4fef9

Add myself as codeowner of previously committed driver. - zephyrproject-rtos#53892 Signed-off-by: TOKITA Hiroshi <[email protected]>

fabiobaltieri pushed a commit that referenced this pull request Aug 3, 2023

CODEOWNERS: add codeowner of dma_rpi_pico

e250dcd

Add myself as codeowner of previously committed driver. - #53892 Signed-off-by: TOKITA Hiroshi <[email protected]>

kunoh pushed a commit to kunoh/zephyr that referenced this pull request Aug 7, 2023

CODEOWNERS: add codeowner of dma_rpi_pico

673bf57

Add myself as codeowner of previously committed driver. - zephyrproject-rtos#53892 Signed-off-by: TOKITA Hiroshi <[email protected]>

drivers: dma: rpi_pico: add support for RaspberryPi Pico DMA #53892

drivers: dma: rpi_pico: add support for RaspberryPi Pico DMA #53892

Uh oh!

Conversation

soburi commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonsch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soburi Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yonsch commented Mar 10, 2023

Uh oh!

yonsch commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teburd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

soburi commented Jan 18, 2023 •

edited

Loading

soburi Mar 9, 2023 •

edited

Loading

soburi Mar 18, 2023 •

edited

Loading

yonsch commented Mar 15, 2023 •

edited

Loading