subsys: fb: cfb: support drawing to any coordinates #53796

soburi · 2023-01-13T23:15:16Z

This PR intends to use cfb like as a graphics oriented devices. It will be fundamental for implements simple graphics rendering.

API improvement:

Allow printing and inverting at any coordinates.

Currently, the CFB API can only draw at tile bounds coordinates (where the y coordinate is a multiple of 8).
Implements dot-by-dot font rendering to make cfb_print() able to draw text even at a coordinate that is not on tile boundaries.
For API consistency, change cfb_invert_area() able to invert even at a coordinate not on tile boundaries.
Add cfb_draw_text() API

Added cfb_draw_text() that does not wrap when specifying the position in dots, as it may be inconvenient if there is wrapping

Shell Improvements:

Add command draw text

Add command to run the new API cfb_draw_text().
This command is similar to print.
The position specify with (x,y) not column-row and doesn't clear buffer is differences.
Add support for running cfb_invert_area().

Extend the invert command to run cfb_invert_area when given four arguments.
Make a change to invert the screen immediately in case of run invert without arguments.

MaureenHelm · 2023-01-26T16:07:49Z

@jfischer-no will you please have a look?

jfischer-no · 2023-01-18T23:09:36Z

subsys/fb/cfb.c

static uint8_t draw_char_vtmono(const struct char_framebuffer *fb, char c, uint16_t x, uint16_t y, bool draw_bg)

Thank you for reviewing.

Align the line start.

jfischer-no · 2023-02-15T15:57:04Z

subsys/fb/cfb.c

What is the benefit of using WRITE_BIT() here?

It make a sense.

I rewrite this code to run less times loop.

jfischer-no · 2023-02-15T16:00:44Z

subsys/fb/cfb.c

Would be nice to have short and concise comments on few points, otherwise no one can understand what happens at first glance.

Add explaining the purpose of each in the process branching.

5frank · 2023-03-01T10:38:01Z

include/zephyr/display/cfb.h

Would be nice with const char *str!? cfb_print should probably also have const parameter IMO.

Thank you for reviewing.
It makes sense.
The function doesn't modify the pointer address and contents.
So, I change the type to const char *const.

cfb_framebuffer_finalize() invert the framebuffer, and it still leave as inverted after executing the function. It restores the framebuffer at the end of the cfb_framebuffer_finalize() for the continued drawing. Signed-off-by: TOKITA Hiroshi <[email protected]>

cfb_print does not modify either address and contents of the pointer that is pointing drawing text. Thus, it can add a const modifier. Signed-off-by: TOKITA Hiroshi <[email protected]>

Implements dot-by-dot font rendering to make cfb_print() able to draw text even at a coordinate that is not on tile boundaries. Signed-off-by: TOKITA Hiroshi <[email protected]>

Add cfb_draw_text() API for rendering text. It is similar to cfb_print(), the difference is cfb_draw_text() accepts coordinate that is not on tile boundaries and don't wrap the line. Signed-off-by: TOKITA Hiroshi <[email protected]>

…e tile Improve `cfb_invert_area()` able to invert even at a coordinate not on tile boundaries. Signed-off-by: TOKITA Hiroshi <[email protected]>

Add the `draw text` command to execute the `cfb_draw_text()` API. The command is similar to the `print` command. The difference is `draw text` can render to coordinate that is not on tile boundaries. The command is not run `cfb_framebuffer_clear()`, So it allows rendering appendiceal with keeping already drawn image. Signed-off-by: TOKITA Hiroshi <[email protected]>

Extend the invert command to run cfb_invert_area when given four arguments. Make a change to invert the screen immediately in case of run invert without arguments. Signed-off-by: TOKITA Hiroshi <[email protected]>

teburd · 2023-03-02T16:57:51Z

@jfischer-no @5frank please look again

soburi · 2023-03-08T04:19:35Z

@5frank
ping

MaureenHelm · 2023-04-06T15:27:26Z

@fabiobaltieri please take a look

I broke the rendering of the CFB_FONT_MSB_FIRST font in the previously committed zephyrproject-rtos#53796. I will correct the entire font rendering process to make it easier to remove the restriction that the vertical size of the font must be a multiple of 8. Signed-off-by: TOKITA Hiroshi <[email protected]>

I broke the rendering of the CFB_FONT_MSB_FIRST font in the previously committed #53796. I will correct the entire font rendering process to make it easier to remove the restriction that the vertical size of the font must be a multiple of 8. Signed-off-by: TOKITA Hiroshi <[email protected]>

I broke the rendering of the CFB_FONT_MSB_FIRST font in the previously committed zephyrproject-rtos#53796. I will correct the entire font rendering process to make it easier to remove the restriction that the vertical size of the font must be a multiple of 8. Signed-off-by: TOKITA Hiroshi <[email protected]>

I broke the rendering of the CFB_FONT_MSB_FIRST font in the previously committed zephyrproject-rtos#53796. I will correct the entire font rendering process to make it easier to remove the restriction that the vertical size of the font must be a multiple of 8. (cherry picked from commit d542e75) Original-Signed-off-by: TOKITA Hiroshi <[email protected]> GitOrigin-RevId: d542e75 Change-Id: Ie6c19b7fd8349c67cb116af7abbde49f4a78997f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5669144 Reviewed-by: Fabio Baltieri <[email protected]> Commit-Queue: Fabio Baltieri <[email protected]> Reviewed-by: Eric Yilun Lin <[email protected]> Tested-by: ChromeOS Prod (Robot) <[email protected]>

soburi requested a review from jfischer-no as a code owner January 13, 2023 23:15

zephyrbot added the area: Display label Jan 13, 2023

soburi force-pushed the cfb_render_on_any_coord branch 2 times, most recently from af1b4db to 786bcc2 Compare January 14, 2023 15:12

soburi requested review from MaureenHelm, carlescufi, galak and nashif as code owners January 14, 2023 15:12

soburi force-pushed the cfb_render_on_any_coord branch 4 times, most recently from 45dbf1a to f925bbe Compare January 14, 2023 23:47

jfischer-no requested changes Feb 15, 2023

View reviewed changes

soburi force-pushed the cfb_render_on_any_coord branch 5 times, most recently from 9fd05cf to d0e71f3 Compare February 19, 2023 07:14

soburi requested a review from jfischer-no February 20, 2023 09:35

soburi force-pushed the cfb_render_on_any_coord branch from d0e71f3 to 63f60ab Compare February 24, 2023 13:57

jfischer-no previously approved these changes Feb 24, 2023

View reviewed changes

5frank reviewed Mar 1, 2023

View reviewed changes

soburi added 7 commits March 2, 2023 22:57

fb: cfb: add const modifier for argument of cfb_print

83f63eb

cfb_print does not modify either address and contents of the pointer that is pointing drawing text. Thus, it can add a const modifier. Signed-off-by: TOKITA Hiroshi <[email protected]>

fb: cfb: support drawing to any coordinates

0aa4606

Implements dot-by-dot font rendering to make cfb_print() able to draw text even at a coordinate that is not on tile boundaries. Signed-off-by: TOKITA Hiroshi <[email protected]>

fb: cfb: Add cfb_draw_text() API

e9c2cdb

Add cfb_draw_text() API for rendering text. It is similar to cfb_print(), the difference is cfb_draw_text() accepts coordinate that is not on tile boundaries and don't wrap the line. Signed-off-by: TOKITA Hiroshi <[email protected]>

fb: cfb: support inverting with coordinates that do not align with th…

1655cd1

…e tile Improve `cfb_invert_area()` able to invert even at a coordinate not on tile boundaries. Signed-off-by: TOKITA Hiroshi <[email protected]>

fb: cfb_shell: support area inverting

75eda27

Extend the invert command to run cfb_invert_area when given four arguments. Make a change to invert the screen immediately in case of run invert without arguments. Signed-off-by: TOKITA Hiroshi <[email protected]>

soburi dismissed jfischer-no’s stale review via 75eda27 March 2, 2023 14:28

soburi force-pushed the cfb_render_on_any_coord branch from 63f60ab to 75eda27 Compare March 2, 2023 14:28

soburi requested a review from 5frank March 2, 2023 14:32

jfischer-no approved these changes Mar 2, 2023

View reviewed changes

MaureenHelm assigned jfischer-no Apr 6, 2023

fabiobaltieri approved these changes Apr 6, 2023

View reviewed changes

carlescufi merged commit 47f14d6 into zephyrproject-rtos:main Apr 6, 2023

soburi mentioned this pull request Apr 12, 2023

cfb: correct invert_area implementaion #56745

Merged

soburi deleted the cfb_render_on_any_coord branch May 28, 2023 11:51

soburi mentioned this pull request Jan 21, 2024

fb: cfb: Fix CFB_FONT_MSB_FIRST font rendering #67881

Merged

subsys: fb: cfb: support drawing to any coordinates #53796

subsys: fb: cfb: support drawing to any coordinates #53796

Uh oh!

Conversation

soburi commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API improvement:

Shell Improvements:

Uh oh!

MaureenHelm commented Jan 26, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teburd commented Mar 2, 2023

Uh oh!

soburi commented Mar 8, 2023

Uh oh!

MaureenHelm commented Apr 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

soburi commented Jan 13, 2023 •

edited

Loading