-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Bluetooth: has: Make HAS registration dynamic #52672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: has: Make HAS registration dynamic #52672
Conversation
c7f55bc to
c9b8c86
Compare
1f35bcf to
16cdc62
Compare
MariuszSkamra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes requested, otherwise LGTM
|
@larsgk Will review after UPF :) |
16cdc62 to
fdc4e33
Compare
MariuszSkamra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the bt_has_hearing_aid_type represent 2 LSB bits in features, you need to redefine the enum values so that:
enum bt_has_hearing_aid_type {
BT_HAS_HEARING_AID_TYPE_BINAURAL = BIT(0),
BT_HAS_HEARING_AID_TYPE_MONAURAL = BIT(1),
BT_HAS_HEARING_AID_TYPE_BANDED = BIT(2),
};
oops - will fix ;) |
bc759fa to
409fb20
Compare
ac850bb to
e97f770
Compare
This changes HAS registration to be dynamic and let's the application set Hearing Aid Type and binaural features. Often, devices are flashed with generic firmware with some features stored post factory production, requiring the settings to be moved from compile time to run-time. This change will increase the RAM usage as the GATT service is moved from ROM to RAM. Signed-off-by: Lars Knudsen <[email protected]> Co-author: Soren Engquist <[email protected]>
e97f770 to
0f73606
Compare
Thalley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we truly want to make HAS dynamically registered, this is OK as it is for me now :)
This changes HAS registration to be dynamic
and let's the application set Hearing Aid Type
Often, devices are flashed with generic firmware with some
features stored post factory production, requiring
the settings to be moved from compile time to run-time.
This change will increase the RAM usage as the GATT
service is moved from ROM to RAM.
Signed-off-by: Lars Knudsen [email protected]
Co-author: Soren Engquist [email protected]