Bluetooth: audio: ascs: Fix possible race condition #52214
Conversation
MariuszSkamra
requested review from
Thalley,
Vudentz,
jhedberg and
sjanc
as code owners
|
I tried this one against PTS BAP/USR/SCC/BV-158-C and AOSP media, call |
MariuszSkamra
force-pushed
the
fix_ase_state_ntf
branch
from
a2effa8 to
5761b5d
Compare
subsys/bluetooth/audio/ascs.c
Outdated
There was a problem hiding this comment.
I know this part was just moved, and it seems like the removal of this is missing from #51030: But ideally Sink ASEs should never autonousmly go into the streaming state - This should only happen as part of calling bt_audio_stream_start on the server side for Sink ASEs, as the Unicast Server application may want to delay going into the streaming state to setup anything related to processing audio.
There was a problem hiding this comment.
As I'm moving the code only, I would rather leave the logic unchanged for now. This can be fixed in another PR
subsys/bluetooth/audio/ascs.c
Outdated
There was a problem hiding this comment.
See my previous comment about autonomously going into the streaming state
MariuszSkamra
force-pushed
the
fix_ase_state_ntf
branch
from
5761b5d to
23df7d4
Compare
MariuszSkamra
force-pushed
the
fix_ase_state_ntf
branch
2 times, most recently
from
7c4e3d5 to
c6daa4f
Compare
subsys/bluetooth/audio/ascs.c
Outdated
There was a problem hiding this comment.
hmm I'm not that much familiar with this code, but this & suggests that ase is container of ep, so this function can be called with ep from some other "pool"?
There was a problem hiding this comment.
Good catch. I did not put much thought while rebasing the code. Looks like I can simply use CONTAINER_OF to get the ASE object
This fixes possible ASE state race condition. The notification is sent immediately once the ASE state changed that eliminates a situation where the state was changed by user action (API function call) when the state was not yet notified to the remote Unicast Client. Fixes: BAP/USR/SCC/BV-158-C Signed-off-by: Mariusz Skamra <[email protected]>
MariuszSkamra
dismissed stale reviews from szymon-czapracki and Thalley
via
5e8d806
MariuszSkamra
force-pushed
the
fix_ase_state_ntf
branch
from
c6daa4f to
5e8d806
Compare
6 participants
This fixes possible ASE state race condition. The notification is sent immediately once the ASE state changed that eliminates a situation where the state was changed by user action (API function call) when the state was not yet notified to the remote Unicast Client.
Fixes: BAP/USR/SCC/BV-158-C
Signed-off-by: Mariusz Skamra [email protected]