Skip to content

Conversation

@o7-machinehum
Copy link

This PR is to implement the driver and API for the iqs5xx trackpad controller

@zephyrbot zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label Oct 20, 2022
@o7-machinehum
Copy link
Author

FYI I'm sure there is a bunch of stuff in the wrong place, and I don't know what needs to happen for APIs to be implemented.

@carlescufi
Copy link
Member

@Machine-Hum thanks for your contribution. Please format your commits according to our guidelines:
https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow

Remember to amend existing commits, not add new ones. Also you will need to remove the merge commit you have now.

@o7-machinehum o7-machinehum changed the title Inplemented iqs5xx driver Implemented iqs5xx driver Oct 20, 2022
@o7-machinehum
Copy link
Author

@carlescufi I think things should look a little better now. Formatted as per the guidelines and ran the clang linter. I tried running twister and it took over 24hrs to get to 75%. Is this normal?

@carlescufi
Copy link
Member

@carlescufi I think things should look a little better now. Formatted as per the guidelines and ran the clang linter. I tried running twister and it took over 24hrs to get to 75%. Is this normal?

You tried to run twister locally? Yes, that's gonna take a long time. Use CI instead of running locally.

Copy link
Contributor

@talih0 talih0 Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to have some callbacks to user when specific events occur?

Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we really need an input subsystem, not another API to handle a type of input device (touch).

@o7-machinehum o7-machinehum reopened this Nov 28, 2022
@o7-machinehum
Copy link
Author

Could someone rerun the workflows please :)

@o7-machinehum
Copy link
Author

I think we really need an input subsystem, not another API to handle a type of input device (touch).

So what's the action on my part? Should this be rewritten? I moved this to #52649 because I broke this PR, it's not updated from my remote. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree Binding PR modifies or adds a Device Tree binding area: Drivers area: Kscan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants