-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Implemented iqs5xx driver #51493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented iqs5xx driver #51493
Conversation
|
FYI I'm sure there is a bunch of stuff in the wrong place, and I don't know what needs to happen for APIs to be implemented. |
|
@Machine-Hum thanks for your contribution. Please format your commits according to our guidelines: Remember to amend existing commits, not add new ones. Also you will need to remove the merge commit you have now. |
|
@carlescufi I think things should look a little better now. Formatted as per the guidelines and ran the clang linter. I tried running twister and it took over 24hrs to get to 75%. Is this normal? |
You tried to run twister locally? Yes, that's gonna take a long time. Use CI instead of running locally. |
drivers/touch/iqs5xx/iqs5xx.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be useful to have some callbacks to user when specific events occur?
gmarull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we really need an input subsystem, not another API to handle a type of input device (touch).
|
Could someone rerun the workflows please :) |
So what's the action on my part? Should this be rewritten? I moved this to #52649 because I broke this PR, it's not updated from my remote. Closing. |
This PR is to implement the driver and API for the iqs5xx trackpad controller