Bluetooth: Audio: Fix bug where sink ep did not go to streaming state #50822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
added
bug
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra and
asbjornsabo
Thalley
force-pushed
the
ascs_sink_ep_streaming_state
branch
3 times, most recently
from
054668f to
024cf6a
Compare
subsys/bluetooth/audio/ascs.c
Outdated
Comment on lines
902
to
903
Contributor
There was a problem hiding this comment.
I'd suggest to assert if stream is non-null as well otherwise
__ASSERT_NO_MSG(ep_state == BT_AUDIO_EP_STATE_IDLE ? stream == NULL : stream != NULL)
Thalley
force-pushed
the
ascs_sink_ep_streaming_state
branch
from
024cf6a to
9e71375
Compare
MariuszSkamra
previously approved these changes
Oct 6, 2022
cvinayak
requested changes
Oct 7, 2022
subsys/bluetooth/audio/ascs.c
Outdated
Contributor
There was a problem hiding this comment.
Have a local variable conn for ase->ascs->conn as it is dereferenced multiple times.
Suggested change
| bt_gatt_notify(ase->ascs->conn, ep->server.attr, | |
| bt_gatt_notify(conn, ep->server.attr, |
If the CIS was connected before the sink endpoint was in the enabling state, it never autonousmly went into the streaming state. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
ascs_sink_ep_streaming_state
branch
from
9e71375 to
4928af2
Compare
cvinayak
approved these changes
Oct 7, 2022
MariuszSkamra
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CIS was connected before the sink endpoint was in the enabling state, it never autonousmly went into the streaming state.
Signed-off-by: Emil Gydesen [email protected]