drivers: usb: create thread and connect IRQ during init #49772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far thread was created as part of usb_dc_attach() by k_thread_create(). This means that if following function were executed: * usb_enable() * usb_disable() * usb_enable() then k_thread_create() was called second time. This results in undefined behavior. Fix above issue by moving k_thread_create() invocation to function called during system initialization. While at it, move IRQ_CONNECT() and irq_enable() invocations to init as well. Signed-off-by: Marcin Niestroj <[email protected]>
So far thread was created as part of usb_dc_attach() by k_thread_create(). This means that if following function were executed: * usb_enable() * usb_disable() * usb_enable() then k_thread_create() was called second time. This results in undefined behavior. Fix above issue by moving k_thread_create() invocation to function called during system initialization. While at it, move IRQ_CONNECT() and irq_enable() invocations to init as well. Signed-off-by: Marcin Niestroj <[email protected]>
So far thread was created as part of usb_dc_attach() by k_thread_create(). This means that if following function were executed: * usb_enable() * usb_disable() * usb_enable() then k_thread_create() was called second time. This results in undefined behavior. Fix above issue by moving k_thread_create() invocation to function called during system initialization. While at it, move IRQ_CONNECT() and irq_enable() invocations to init as well. Signed-off-by: Marcin Niestroj <[email protected]>
Thread name is useful when debugging or using shell with CONFIG_THREAD_NAME=y. Signed-off-by: Marcin Niestroj <[email protected]>
Thread name is useful when debugging or using shell with CONFIG_THREAD_NAME=y. Signed-off-by: Marcin Niestroj <[email protected]>
Thread name is useful when debugging or using shell with CONFIG_THREAD_NAME=y. Signed-off-by: Marcin Niestroj <[email protected]>
bbilas
approved these changes
Sep 1, 2022
jfischer-no
approved these changes
Sep 2, 2022
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far thread was created as part of
usb_dc_attach()byk_thread_create().This means that if following function were executed:
usb_enable()usb_disable()usb_enable()then
k_thread_create()was called second time. This results in undefinedbehavior.
Fix above issue by moving
k_thread_create()invocation to function calledduring system initialization.
While at it, move
IRQ_CONNECT()andirq_enable()invocations to init aswell.
Set thread names, which are useful when debugging or using shell with
CONFIG_THREAD_NAME=y.