Skip to content

Conversation

@MeisterBob
Copy link

Add jlink configuration to rpi_pico

closes #48194

@MeisterBob MeisterBob requested a review from yonsch as a code owner August 26, 2022 07:06
@soburi soburi self-requested a review August 26, 2022 09:36
@soburi
Copy link
Member

soburi commented Aug 26, 2022

And need to update document.

@soburi soburi added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Aug 26, 2022
@MeisterBob MeisterBob requested a review from nashif as a code owner August 29, 2022 06:54
@MeisterBob
Copy link
Author

moved the include statement to the bottom of board.cmake and added a few lines to the documentation.

Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to trouble you, but could you please remove the outdated article about J-Link in the documentation and update it?

Copy link
Member

@soburi soburi Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the 'Using an SWD adapter' section, and the JLink debug probe is not an SWD adapter.

End of this section, line
https://github.com/zephyrproject-rtos/zephyr/blame/52fe06495dc2d9bfa394353778c3f211441a65fb/boards/arm/rpi_pico/doc/index.rst#L134-L139
is mentioned about how to use JLink.
I think it should be replaced with a new section (I think it is good to be titled 'Using J-Link adapter')
and put this command line into it. (quote by .. code-block:: console)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call the JLink a SWD (and JTAG, SPI, ...) adapter. I could split it up into Using jlink and Using openocd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call the JLink a SWD (and JTAG, SPI, ...) adapter.
Sorry, This is correct.

I could split it up into Using jlink and Using openocd
👍
It is more kindly for users. Thank you for suggestion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging section also mentions about J-Link using.
https://github.com/zephyrproject-rtos/zephyr/blame/52fe06495dc2d9bfa394353778c3f211441a65fb/boards/arm/rpi_pico/doc/index.rst#L172-L190

We can replace this lines with

west debug --runner jlink

@codecov-commenter
Copy link

Codecov Report

Merging #49563 (52fe064) into main (88aa873) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 52fe064 differs from pull request most recent head 9e58b0e. Consider uploading reports for the commit 9e58b0e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #49563      +/-   ##
==========================================
- Coverage   49.95%   49.94%   -0.01%     
==========================================
  Files         669      669              
  Lines       83642    83710      +68     
  Branches    19738    19745       +7     
==========================================
+ Hits        41780    41806      +26     
- Misses      34897    34929      +32     
- Partials     6965     6975      +10     
Impacted Files Coverage Δ
boards/posix/native_posix/main.c 78.26% <0.00%> (-21.74%) ⬇️
subsys/testsuite/ztest/src/ztest_new.c 71.92% <0.00%> (-3.92%) ⬇️
subsys/net/lib/config/init.c 44.27% <0.00%> (-1.53%) ⬇️
subsys/settings/src/settings_file.c 68.89% <0.00%> (-0.96%) ⬇️
include/zephyr/sys/time_units.h 97.51% <0.00%> (-0.50%) ⬇️
lib/os/bitarray.c 80.68% <0.00%> (-0.38%) ⬇️
subsys/net/lib/lwm2m/lwm2m_obj_firmware.c 17.08% <0.00%> (-0.36%) ⬇️
drivers/spi/spi_test.c 33.33% <0.00%> (ø)
include/zephyr/drivers/spi.h 68.75% <0.00%> (ø)
include/zephyr/sys/cbprintf.h 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88aa873...9e58b0e. Read the comment docs.

Add jlink configuration.

Signed-off-by: Gerhard Jörges <[email protected]>
Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlescufi carlescufi merged commit d835c1b into zephyrproject-rtos:main Aug 31, 2022
@MeisterBob MeisterBob deleted the rp2040_jlink branch August 31, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support J-Link debugger for RaspberryPi Pico

6 participants