-
Notifications
You must be signed in to change notification settings - Fork 8.2k
boards: arm: rpi_pico: add jlink runner conf #49563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
And need to update document.
|
91e0dae to
9e58b0e
Compare
|
moved the include statement to the bottom of |
soburi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry to trouble you, but could you please remove the outdated article about J-Link in the documentation and update it?
boards/arm/rpi_pico/doc/index.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the 'Using an SWD adapter' section, and the JLink debug probe is not an SWD adapter.
End of this section, line
https://github.com/zephyrproject-rtos/zephyr/blame/52fe06495dc2d9bfa394353778c3f211441a65fb/boards/arm/rpi_pico/doc/index.rst#L134-L139
is mentioned about how to use JLink.
I think it should be replaced with a new section (I think it is good to be titled 'Using J-Link adapter')
and put this command line into it. (quote by .. code-block:: console)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call the JLink a SWD (and JTAG, SPI, ...) adapter. I could split it up into Using jlink and Using openocd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call the JLink a SWD (and JTAG, SPI, ...) adapter.
Sorry, This is correct.
I could split it up into Using jlink and Using openocd
👍
It is more kindly for users. Thank you for suggestion.
boards/arm/rpi_pico/doc/index.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debugging section also mentions about J-Link using.
https://github.com/zephyrproject-rtos/zephyr/blame/52fe06495dc2d9bfa394353778c3f211441a65fb/boards/arm/rpi_pico/doc/index.rst#L172-L190
We can replace this lines with
west debug --runner jlink
Codecov Report
@@ Coverage Diff @@
## main #49563 +/- ##
==========================================
- Coverage 49.95% 49.94% -0.01%
==========================================
Files 669 669
Lines 83642 83710 +68
Branches 19738 19745 +7
==========================================
+ Hits 41780 41806 +26
- Misses 34897 34929 +32
- Partials 6965 6975 +10
Continue to review full report at Codecov.
|
Add jlink configuration. Signed-off-by: Gerhard Jörges <[email protected]>
9e58b0e to
8654a86
Compare
soburi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add jlink configuration to rpi_pico
closes #48194