Bluetooth: audio: Fix error message in PACS

[szymon-czapracki]

Change error code in PACS source/sink write operation to Write Request Rejected.

[szymon-czapracki]

@MariuszSkamra FYI

[Thalley]

@szymon-czapracki I don't think I agree with this change. What's the rationale for changing these? PTS tests failing? And if so, does the test spec specifically require this particular result code?

[szymon-czapracki]

@szymon-czapracki I don't think I agree with this change. What's the rationale for changing these? PTS tests failing? And if so, does the test spec specifically require this particular result code?

Exactly as you suspected, PTS tests are failing. But there is also a description of proper behaviour in spec:

But there is still a question if we should return this code on occasion when there is no callback present.

[Thalley]

@szymon-czapracki I don't think I agree with this change. What's the rationale for changing these? PTS tests failing? And if so, does the test spec specifically require this particular result code?

Exactly as you suspected, PTS tests are failing. But there is also a description of proper behaviour in spec:

But there is still a question if we should return this code on occasion when there is no callback present.

Thanks. then it should be changed for most part here, yes. Perhaps we should check if other services have similar text, and if not we should perhaps consider changing that there to be consistent across the services.

For the offset check I still think we should use BT_ATT_ERR_INVALID_OFFSET as that has nothing to do with the length nor the RFU values.

Whether or not the BT_ATT_ERR_AUTHORIZATION should be changed as well I am unsure, but either way works there I guess :)