Skip to content

drivers: spi: gd32: Add support DMA transfer #47504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 11, 2023
Merged

drivers: spi: gd32: Add support DMA transfer #47504

merged 4 commits into from
Jan 11, 2023

Conversation

@soburi
Copy link
Member

@soburi soburi commented Jul 7, 2022 •
edited
Loading

Add supporting DMA-based transfer for GD32 SPI.

Signed-off-by: TOKITA Hiroshi [email protected]

@soburi soburi marked this pull request as draft July 7, 2022 14:24
@zephyrbot zephyrbot added area: SPI SPI bus area: Devicetree platform: GD32 GigaDevice area: DMA Direct Memory Access labels Jul 7, 2022
@nandojve nandojve mentioned this pull request Jul 9, 2022
Open
55 tasks
mbolivar-nordic
mbolivar-nordic reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teburd -- I'm trying to take a step back from reviewing subsystem-specific DT changes in favor of asking those subsystem maintainers to take this on. I'm going to leave this up to you -- please feel free to ping if you have any specific questions

@soburi soburi mentioned this pull request Aug 1, 2022
Merged
@nandojve
Copy link
Member

nandojve commented Aug 2, 2022

Hi @soburi ,

You can rebase since #47501 got merge.

@soburi soburi force-pushed the gd32_spi_dma branch 3 times, most recently from 4bbb8c6 to f443540 Compare August 4, 2022 23:43
@soburi soburi marked this pull request as ready for review August 5, 2022 00:05
@soburi soburi changed the title [draft] drivers: spi: gd32: Add support DMA transfer drivers: spi: gd32: Add support DMA transfer Aug 5, 2022
@zephyrbot zephyrbot requested a review from cameled August 5, 2022 00:05
@soburi
Copy link
Member Author

soburi commented Aug 5, 2022

Hi, @nandojve , @cameled
Thank you for your continued support.
As with #47501, please review it.

@soburi soburi requested a review from mbolivar-nordic August 5, 2022 00:11
galak
galak previously requested changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use standard dmas property.

dts/bindings/spi/gd,gd32-spi.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this using a dmas property like dts/bindings/spi/atmel,sam0-spi.yaml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will apply your pointing out.
dma-gd32.c need fix prior than spi,
so I create new PR #48756.
Could you please review also it?

@cameled
Copy link
Contributor

cameled commented Aug 5, 2022

@soburi In general, gd32 evaluate boards have a spi flash. I have tried to run dma on that spi flash from gd32f450i_eval board, but looks there have something blocked. I will try to dig out tomorrow. Anyway, this is an impressive work.

@soburi soburi mentioned this pull request Aug 6, 2022
Merged
@soburi soburi marked this pull request as ready for review December 22, 2022 13:55
@zephyrbot zephyrbot added the area: RISCV RISCV Architecture (32-bit & 64-bit) label Dec 22, 2022
@soburi soburi requested a review from cameled December 22, 2022 15:35
cameled
cameled requested changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@cameled cameled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, some need to confirm.

cameled
cameled reviewed Jan 4, 2023
View reviewed changes
@soburi soburi force-pushed the gd32_spi_dma branch 3 times, most recently from 8de7948 to 9fa3151 Compare January 6, 2023 13:00
@soburi soburi requested a review from cameled January 6, 2023 20:43
@nandojve nandojve requested a review from galak January 7, 2023 12:34
nandojve
nandojve requested changes Jan 7, 2023
View reviewed changes
@soburi soburi requested a review from nandojve January 8, 2023 03:47
cameled
cameled reviewed Jan 8, 2023
View reviewed changes
Copy link
Contributor

@cameled cameled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add some suggestion.

cameled
cameled reviewed Jan 8, 2023
View reviewed changes
soburi added 4 commits January 9, 2023 13:08
@soburi
drivers: spi: gd32: Add support DMA transfer
579bad5 
Add supporting DMA-based transfer for GD32 SPI.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
tests: spi: spi_loopback: add interrupt and DMA tests for GD32 boards
4a6cf04 
Add interrupt and DMA tests for GD32 boards.
Use overlay-gd32-spi-interrupt.conf when testing interrupt based transfer,
use overlay-gd32-spi-dma.conf when testing DMA transfer,

Add overlay file for GD32 boards for these tests.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
boards: gd32: add spi as supported feature
0f3a7fd 
Add `spi` as supported feature to yaml configuration.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
boards: gd32f450i_eval: Enable DMA transfer for nor-flash
9bd4f59 
Enable DMA transfer via SPI bus for nor-flash.

Signed-off-by: TOKITA Hiroshi <[email protected]>
nandojve
nandojve approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @soburi !

@mbolivar-nordic mbolivar-nordic merged commit fed4e18 into zephyrproject-rtos:main Jan 11, 2023
@soburi soburi deleted the gd32_spi_dma branch January 11, 2023 20:32
@soburi soburi mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teburd teburd teburd approved these changes

@nandojve nandojve nandojve approved these changes

@fkokosinski fkokosinski fkokosinski approved these changes

@cameled cameled cameled approved these changes

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@nashif nashif Awaiting requested review from nashif

@kgugala kgugala Awaiting requested review from kgugala

@pgielda pgielda Awaiting requested review from pgielda

@gmarull gmarull Awaiting requested review from gmarull

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

@carlescufi carlescufi Awaiting requested review from carlescufi

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@tgorochowik tgorochowik Awaiting requested review from tgorochowik

@galak galak Awaiting requested review from galak

Assignees

@nandojve nandojve

Labels

area: Devicetree area: DMA Direct Memory Access area: RISCV RISCV Architecture (32-bit & 64-bit) area: SPI SPI bus platform: GD32 GigaDevice

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

8 participants

@soburi @nandojve @cameled @teburd @galak @fkokosinski @mbolivar-nordic @zephyrbot