Reset controller bug #46057
Merged
Reset controller bug #46057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-edward-popa
requested review from
MaureenHelm,
carlescufi,
galak and
nashif
as code owners
github-actions
bot
added
area: API
andrei-edward-popa
force-pushed
the
reset_controller_bug
branch
from
4a5e5fd to
2e775d8
Compare
fabiobaltieri
previously approved these changes
May 26, 2022
Member
fabiobaltieri
left a comment
fabiobaltieri
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
stephanosio
previously approved these changes
May 26, 2022
Member
stephanosio
left a comment
stephanosio
left a comment
There was a problem hiding this comment.
Looking at toggle and status, it would make sense to prefix them with line_ as well for the sake of consistency, but no strong opinion here.
Contributor
|
Yes, please fix |
carlocaione
previously approved these changes
May 26, 2022
Contributor
carlocaione
left a comment
carlocaione
left a comment
There was a problem hiding this comment.
Approved but open a new PR to fix the remaining hooks.
stephanosio
added
the
Hotfix
Contributor
Author
I will do it in this PR soon. @carlocaione Also the status or the toggle only? |
assert API function needed to be changed because of newlib assert macro name conflict Signed-off-by: Andrei-Edward Popa <[email protected]>
added reset controller in release notes 3.1 Signed-off-by: Andrei-Edward Popa <[email protected]>
andrei-edward-popa
dismissed stale reviews from carlocaione, stephanosio, and fabiobaltieri
via
85421e1
andrei-edward-popa
force-pushed
the
reset_controller_bug
branch
from
2e775d8 to
85421e1
Compare
Contributor
Author
Done only for toggle. |
stephanosio
approved these changes
May 26, 2022
carlocaione
approved these changes
May 26, 2022
gmarull
approved these changes
May 26, 2022
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussion in issue #46023 I changed the assert and deassert names from reset controller driver API to line_assert and line_deassert because of newlib assert macro. Also, I added in another commit the reset controller as new driver inside release notes 3.1.