-
Notifications
You must be signed in to change notification settings - Fork 8.2k
boards: arm: rpi_pico: add openocd runner configuration #45137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: arm: rpi_pico: add openocd runner configuration #45137
Conversation
c06241f to
cee6eb3
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
yonsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall, I have just one question:
Does this work with the openocd found in zephyr-sdk, or does it use a custom version of openocd? I couldn't find target/rp2040.cfg (though I did find rp2040-core0.cfg), and neither interface/picoprobe/interface/raspberrypi-swd.
|
Hi! @yonsch
It requires a custom version openocd. I missed writing information about the distribution source of the custom version. There is an easy way to use this version of openocd is running the setup.sh script for setting up the pico development environment. I wrote it in the document. |
|
I tested this yesterday evening with the picoprobe. There are couple remarks I have regarding the documentation of this:
|
|
Hi, @burumaj
Thanks for testing it and comments. |
cee6eb3 to
0f64d04
Compare
yonsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few comments about the documentation.
boards/arm/rpi_pico/doc/index.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that you've added a link, this line can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this line.
boards/arm/rpi_pico/doc/index.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it
Add openocd configuration. This configuration allows selecting what debug adapter debugging rpi_pico by a command-line argument. It is mainly intended to support both the 'picoprobe' and 'raspberrypi-swd' adapter described in "Getting started with Raspberry Pi Pico". And any other SWD debug adapter might also be usable with this configuration. Signed-off-by: TOKITA Hiroshi <[email protected]>
0f64d04 to
3303358
Compare
|
I would suggest adding jlink support to board.cmake as well |
|
Hi, @MeisterBob Thanks for comment.
It seems good. Please consider it. |
|
@MeisterBob , (Simply reason, I can't verify the code within this PR becasuse I don't have J-Link debugger...) |
Add openocd configuration.
This configuration allows selecting what debug adapter debugging rpi_pico
by a command-line argument.
It is mainly intended to support both the 'picoprobe' and 'raspberrypi-swd'
adapter described in "Getting started with Raspberry Pi Pico".
And any other SWD debug adapter might also be usable with this configuration.