Bluetooth: Immediate Alert Client #44794
Conversation
github-actions
bot
added
area: API
|
@MariuszSkamra fyi |
szymon-czapracki
force-pushed
the
ias_client
branch
from
9ce3a27 to
92b81a4
Compare
szymon-czapracki
force-pushed
the
ias_client
branch
3 times, most recently
from
e4ba8a2 to
e978cc5
Compare
szymon-czapracki
requested review from
Vudentz,
alwa-nordic and
jhedberg
as code owners
There was a problem hiding this comment.
Do we need to reset the client on disconnect? Would it make more sense to reset the client when bt_ias_discover is called, so that we don't perform any operations on disconnecting connections that never did any IAS stuff?
There was a problem hiding this comment.
I've made a change so on discovery we are doing:
client->conn = bt_conn_ref(conn)
And then we check on disconnect whether client->conn isn't NULL, and if not - we call client_reset() with bt_conn_unref() within. Is this approach correct?
There was a problem hiding this comment.
I don't think so.
Since we are not suing using the ias_client as a application struct, and we simply use the conn index for lookups, there's no reason to store the bt_conn in the ias client struct.
A much simpler approach is to simply call client_reset in the bt_ias_discover and remove the disconnected callback, as that doesn't really serve any purpose.
There was a problem hiding this comment.
As we are doing reset in bt_ias_discover now can we mark this as resolved?
szymon-czapracki
force-pushed
the
ias_client
branch
from
e978cc5 to
3064517
Compare
github-actions
bot
added
the
area: Tests
szymon-czapracki
force-pushed
the
ias_client
branch
5 times, most recently
from
f399ef3 to
cc88d5d
Compare
szymon-czapracki
force-pushed
the
ias_client
branch
from
cc88d5d to
57a6fe6
Compare
szymon-czapracki
force-pushed
the
ias_client
branch
2 times, most recently
from
e939645 to
e605606
Compare
|
@Thalley @MariuszSkamra I've added another commit with shell implementation for IAS within this PR, if you could take a look at it with your next review that would be great :) |
szymon-czapracki
requested review from
MariuszSkamra
and removed request for
Casper-Bonde-Bose,
Vudentz,
alwa-nordic,
asbjornsabo,
hermabe,
jhedberg,
jori-nordic and
sjanc
szymon-czapracki
force-pushed
the
ias_client
branch
from
b236c89 to
cea643b
Compare
zephyrbot
requested review from
Casper-Bonde-Bose,
Vudentz,
alwa-nordic,
asbjornsabo,
hermabe,
jhedberg,
jori-nordic and
sjanc
Implement Immediate Alert Client Move IAS into separate subdirectory Signed-off-by: Szymon Czapracki <[email protected]> general fixes
This commit adds IAS functionality to the shell. Signed-off-by: Szymon Czapracki <[email protected]> shell fixes
Add babblesim tests for IAS. Signed-off-by: Szymon Czapracki <[email protected]>
szymon-czapracki
force-pushed
the
ias_client
branch
from
cea643b to
b2bac6a
Compare
|
@jhedberg is away this week so merging to get this in time for the release. |
6 participants
Add Immediate Alert Service client.
Move IAS into separate subdirectory.
Add IAS shell.
fixes #44055