iMX RT full pinctrl enablement #44150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldegrasse
requested review from
MaureenHelm,
anangl,
dleach02,
galak,
gmarull,
loicpoulain,
mmahadevan108,
mnkp,
pfalcon and
tbursztyka
as code owners
github-actions
bot
added
area: Boards
area: Devicetree
platform: NXP
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
29 tasks
Contributor
Author
|
@hakehuang Can you run CI against this PR? It should only need to be tested on iMX RT boards |
Contributor
@danieldegrasse , I run regression on below boards, no issue found, all cases PASS. |
zephyrbot
requested review from
henrikbrixandersen,
jfischer-no and
mbolivar-nordic
gmarull
reviewed
Mar 24, 2022
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
Overall LGTM, I have a couple of minor questions
gmarull
previously approved these changes
Mar 24, 2022
gmarull
previously approved these changes
Mar 25, 2022
Update nxp hal revision in west.yml to include new pinctrl definition header files. Signed-off-by: Daniel DeGrasse <[email protected]>
Add pinctrl definitions for all iMX RT based boards Signed-off-by: Daniel DeGrasse <[email protected]>
iMX.RT parts use a GPR register for some pinmux settings. Update pinctrl driver to support this GPR register definition. Signed-off-by: Daniel DeGrasse <[email protected]>
RT11xx series has similar pin configuration peripheral to RT10xx, with some differences in register layout. Create new pinctrl definition header file, and reuse existing driver code for RT10xx. Signed-off-by: Daniel DeGrasse <[email protected]>
Enable pinctrl for mcux_12b1msps_sar adc driver Signed-off-by: Daniel DeGrasse <[email protected]>
enable pinctrl for mcux lpc lpadc driver Signed-off-by: Daniel DeGrasse <[email protected]>
Enable pinctrl for nxp imx_pwm driver Signed-off-by: Daniel DeGrasse <[email protected]>
Enable pinctrl for flexspi driver. Note that when flexspi is being using in XIP mode, pinctrl settings are not required and will not be applied. Pinctrl settings are only required when the flexspi device being used is not the one used for XIP. Signed-off-by: Daniel DeGrasse <[email protected]>
Enable pinctrl for mcux_csi video driver Signed-off-by: Daniel DeGrasse <[email protected]>
add pinctrl support for display_mcux_elcdif driver Signed-off-by: Daniel DeGrasse <[email protected]>
Enable pinctrl driver for usdhc. USDHC driver uses custom pinctrl states for fast, slow, and medium signal frequencies, as well as pin pull for SD detection. Signed-off-by: Daniel DeGrasse <[email protected]>
In order for pinctrl support to be complete, RT series GPIO driver must support pinmuxing within the driver level. RT series pinmux settings do not correspond directly to gpio port/pin numbers, so use DTS mappings to pinctrl nodes to select and apply pinmux settings in the gpio driver. Signed-off-by: Daniel DeGrasse <[email protected]>
Add backlight gpios property to mcux display driver, so that the driver can correctly initialize the backlight gpio control. Signed-off-by: Daniel DeGrasse <[email protected]>
add support for resetting phy at boot via GPIO reset pin. Signed-off-by: Daniel DeGrasse <[email protected]>
Enable soc ethernet ref clock output at the SOC level instead of board level, since it is required for all iMX.RT SOCs Signed-off-by: Daniel DeGrasse <[email protected]>
imx.rt boards support pinctrl. Remove pinmux settings Signed-off-by: Daniel DeGrasse <[email protected]>
All iMX RT 1xxx boards are now expected to use pin control, so the USDHC pinmuxing callbacks can be removed. Signed-off-by: Daniel DeGrasse <[email protected]>
danieldegrasse
dismissed stale reviews from MaureenHelm and gmarull
via
40526f8
dleach02
approved these changes
Mar 25, 2022
gmarull
approved these changes
Mar 25, 2022
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the pin control API for all in tree iMX RT boards and drivers. It includes the following changes:
Dependent upon #43293 for missing GPIO definitions in RT1170 devicetree