soc: esp32: linker script updates #43659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioalves
requested review from
andyross,
dcpleung,
kgugala,
nashif and
pgielda
as code owners
sylvioalves
commented
Mar 10, 2022
zephyrbot
added
area: RISCV
zephyrbot
requested review from
edersondisouza,
glaubermaroto,
henrikbrixandersen,
katsuster,
mgielda,
tgorochowik and
uLipe
sylvioalves
force-pushed
the
bugfix/esp32_family_linker_cleanup
branch
3 times, most recently
from
ef58e74 to
626ff0d
Compare
Contributor
Author
|
Removed snippets commit from this PR to #43725. |
sylvioalves
force-pushed
the
bugfix/esp32_family_linker_cleanup
branch
from
626ff0d to
7f8c704
Compare
dcpleung
reviewed
Mar 15, 2022
sylvioalves
force-pushed
the
bugfix/esp32_family_linker_cleanup
branch
from
7f8c704 to
055eb17
Compare
sylvioalves
commented
Mar 16, 2022
sylvioalves
force-pushed
the
bugfix/esp32_family_linker_cleanup
branch
from
98b2a14 to
ad24790
Compare
Contributor
Author
|
@dcpleung Added your suggestion/PR. |
Member
|
LGTM |
uLipe
previously approved these changes
Apr 13, 2022
glaubermaroto
previously approved these changes
Apr 13, 2022
sylvioalves
force-pushed
the
bugfix/esp32_family_linker_cleanup
branch
from
ad24790 to
0a6040c
Compare
Contributor
Author
|
Rebased to add latest BT_IAS config. |
sylvioalves
requested review from
glaubermaroto and
uLipe
and removed request for
uLipe
mbolivar-nordic
previously approved these changes
Apr 15, 2022
Contributor
mbolivar-nordic
left a comment
mbolivar-nordic
left a comment
There was a problem hiding this comment.
This looks reasonable to me.
glaubermaroto
previously approved these changes
Apr 21, 2022
Contributor
|
Needs rebase |
This splits common-rom.ld into smaller snippets so that these chunks can be placed at different locations if so desired. Signed-off-by: Daniel Leung <[email protected]>
This PR removes common-rom.ld section so that logging sections can now be mapped into RAM area. Signed-off-by: Sylvio Alves <[email protected]>
This PR removes common-rom.ld section so that logging sections can now be mapped into RAM area. Signed-off-by: Sylvio Alves <[email protected]>
This PR removes common-rom.ld section so that logging sections can now be mapped into RAM area. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
dismissed stale reviews from glaubermaroto and mbolivar-nordic
via
bfa069c
sylvioalves
force-pushed
the
bugfix/esp32_family_linker_cleanup
branch
from
0a6040c to
bfa069c
Compare
Contributor
Author
|
Rebased and re-organized |
glaubermaroto
approved these changes
Apr 26, 2022
dcpleung
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
common-rom.ldinto smaller linker files to enable custom placement of sections. It also updates ESP32 family to make use of this approach.This is useful for architectures as such as ESP32 that requires log strings to be placed in RAM area
due to flash cache access. It can also be useful for applications that have small ROM footprint.