net: app: Bind to correct address family #4356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfalcon
reviewed
Oct 16, 2017
subsys/net/lib/app/client.c
Outdated
There was a problem hiding this comment.
There's also "peer_addr" arg to this function (net_app_init_client), shouldn't it be consulted to avoid extra name resolution run?
Also, later we'd need to resolve peer_addr_str anyway, so make sense to do that once, though looking at the code, that would require heavier refactoring of the code...
|
New version uploaded, I also added simple unit tests that test the refactored client APIs. |
Use the remote address to determine what address family to bind. This prevents extra context to be created. In order to avoid parsing the peer address string multiple times, the client init function is re-factored. Signed-off-by: Jukka Rissanen <[email protected]>
If there is no connection to server, then _net_app_select_net_ctx() will return NULL. This is perfectly fine and we can just continue. Signed-off-by: Jukka Rissanen <[email protected]>
jukkar
force-pushed
the
net-app-fix
branch
2 times, most recently
from
6c7c731 to
8a334a9
Compare
pfalcon
approved these changes
Oct 17, 2017
These are simple tests for net-app testing. These do not try to actually send anything to net but test mainly net-app setup and close functionality. Signed-off-by: Jukka Rissanen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the remote address to determine what address family to bind.
This prevents extra context to be created.
Signed-off-by: Jukka Rissanen [email protected]