soc: arm: nxp: kinetis: fix pinctrl compilation for ke1xf SoC series #43486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikbrixandersen
added
bug
henrikbrixandersen
requested review from
dleach02 and
mmahadevan108
as code owners
The NXP KE1xF SoC series does not support neither slew rate nor open drain PORT configuration registers. Fix pinctrl compilation for the KE1xF by defining dummy register macros for the SRE and ODE registers. Signed-off-by: Henrik Brix Andersen <[email protected]>
henrikbrixandersen
force-pushed
the
nxp_ke1xf_pinctrl_no_slew_rate_no_open_drain
branch
from
ec1c11b to
518b176
Compare
danieldegrasse
approved these changes
Mar 7, 2022
Contributor
danieldegrasse
left a comment
danieldegrasse
left a comment
There was a problem hiding this comment.
Thanks for the fix- sorry that this wasn't caught in the initial PR
dleach02
approved these changes
Mar 7, 2022
henrikbrixandersen
deleted the
nxp_ke1xf_pinctrl_no_slew_rate_no_open_drain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NXP KE1xF SoC series does not support neither slew rate nor open drain PORT configuration registers.
Fix pinctrl compilation for the KE1xF by defining dummy register macros for the SRE and ODE registers.
Signed-off-by: Henrik Brix Andersen [email protected]