-
Notifications
You must be signed in to change notification settings - Fork 8.2k
soc: esp32: Added rodata injection to esp32 build #42263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uLipe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside the comments, LGTM
When building for ESP32, the linker scripts were not loaded by zephyr_linker_sources. This PR fixes that and allows custom linker scripts to be added to the build. Thanks to @sylvioalves for the solution. Signed-off-by: Kamel Makhloufi [email protected]
|
Hey @sylvioalves, I tried to do the requested changes but I am bad at git commits and PR requests, so let me know if I should redo it again. Sorry for the inconvenience, not used to working on big projects like this one. |
You can check current errors in here: https://github.com/zephyrproject-rtos/zephyr/runs/4997252486?check_suite_focus=true
|
|
Merged #43725 |
When building for ESP32, the linker scripts were not loaded by zephyr_linker_sources.
This PR fixes that and allows custom linker scripts to be added to the build.
Shoutout to Sylvio on Zephyr discord for the solution.
Signed-off-by: Kamel Makhloufi [email protected]