pinctrl: add STM32 implementation #40194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
requested review from
ABOSTM,
FRASTM,
Mani-Sadhasivam,
MaureenHelm,
alexanderwachter,
avisconti,
galak,
gmarull,
jackrosenthal,
jfischer-no,
loicpoulain,
martinjaeger,
nashif,
nvlsianpu,
sidcha and
tbursztyka
as code owners
github-actions
bot
added
area: Boards
area: Devicetree
platform: STM32
gmarull
approved these changes
Nov 9, 2021
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
LGTM, a couple of minor comments. Another suggestion: drivers now depend on CONFIG_PINCTRL=y, so should we specify such dependency in Kconfig?
Member
Author
|
@gmarull Thanks for the review
Most drivers also depends on CLOCK_CONTROL and this dependency is not specified. |
Member
|
Another suggestion: may be useful to add a test for DT parsing: 50bd669 |
erwango
force-pushed
the
dev_pinctrl_stm32
branch
from
7cc42e4 to
75dd073
Compare
zephyrbot
added
area: Continuous Integration
area: Build System
area: PWM
Use the new pinctrl API to configure pins. Signed-off-by: Erwan Gouriou <[email protected]>
Use the new pinctrl API to configure pins. Additionally, rename eth0_pins to eth0_pcfg to better fit new pinctrl API. Signed-off-by: Erwan Gouriou <[email protected]>
Add the pinctrl state name (default) for the QSPI peripherals. Signed-off-by: Erwan Gouriou <[email protected]>
Use the new pinctrl API to configure pins. Signed-off-by: Erwan Gouriou <[email protected]>
There's no QSPI peripheral device available on this board. Remove node definition. Signed-off-by: Erwan Gouriou <[email protected]>
Add the pinctrl state name (default) for the I2C peripherals. Changes performed based on the script proposed in "boards: arm: stm32: add pinctrl state name for UART peripheral" Signed-off-by: Erwan Gouriou <[email protected]>
Use the new pinctrl API to configure pins. Signed-off-by: Erwan Gouriou <[email protected]>
Add the pinctrl state name (default) for the I2S peripherals. Signed-off-by: Erwan Gouriou <[email protected]>
Use the new pinctrl API to configure pins. Signed-off-by: Erwan Gouriou <[email protected]>
Add the pinctrl state name (default) for the FMC peripherals. Signed-off-by: Erwan Gouriou <[email protected]>
Use the new pinctrl API to configure pins. Signed-off-by: Erwan Gouriou <[email protected]>
Add the pinctrl state name (default) for the CAN peripherals. Changes performed based on the script proposed in "boards: arm: stm32: add pinctrl state name for UART peripheral" Signed-off-by: Erwan Gouriou <[email protected]>
Use the new pinctrl API to configure pins. Signed-off-by: Erwan Gouriou <[email protected]>
Add the pinctrl state name (default) for the USB peripherals. Signed-off-by: Erwan Gouriou <[email protected]>
Use the new pinctrl API to configure pins. Additionally, rename usb_pinctrl to usb_pcfg to better fit new pinctrl API. Signed-off-by: Erwan Gouriou <[email protected]>
Add the pinctrl state name (default) for the PWM peripherals. Changes performed based on the script proposed in "boards: arm: stm32: add pinctrl state name for UART peripheral" Signed-off-by: Erwan Gouriou <[email protected]>
Use the new pinctrl API to configure pins. Since STM32F1 series require pinctrl option and required register address is parent timer address in place of own node register address, use PINCTRL_DT_INST_CUSTOM_REG_DEFINE in place of usual PINCTRL_DT_INST_DEFINE for this specific series. Additionally, remove the automatic selection of PINMUX API. Signed-off-by: Erwan Gouriou <[email protected]>
Now that all drivers and all boards have been converted to the use of PINCTRL, remove usage of PINMUX. Signed-off-by: Erwan Gouriou <[email protected]>
Now that STM32 drivers are using pinctrl API, set pintrl-0 and pintrl-names properties as required in order to report malformed nodes description soon at build stage and avoid cryptic DT api build error messages. Signed-off-by: Erwan Gouriou <[email protected]>
Set SPI nodes status as disabled, as this should be the in .dtsi soc description. Signed-off-by: Erwan Gouriou <[email protected]>
On stm32l5 based boards, some serial devices descriptions were scattered between common.dtsi and base or non secure dts files. This leads to build issues now that pinctrl-0 and pinctrl-names properties are required but this was anyway broken since the beginning. Group all serial devices definition in common.dtsi so complete devices description is available to both non secure and base descriptions. Signed-off-by: Erwan Gouriou <[email protected]>
Now that pinctrl-0 property is required in descriptions of nodes that implies definition of pins, these incomplete nodes definitions lead to build error. Fix or remove depending of the board documentation. Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
dev_pinctrl_stm32
branch
from
016ab92 to
d9a1b82
Compare
erwango
force-pushed
the
dev_pinctrl_stm32
branch
from
944cdf6 to
9aae839
Compare
Pinctrl is missing in i2c1 device description on stm32373c_eval ovderlay file, besides using I2C1 this board (as mentioned in readme) requires to remove 2 resistors on the board. Make it simple and instead use a board with arduino_i2c port available. Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
dev_pinctrl_stm32
branch
from
9aae839 to
f59f1b3
Compare
Member
Author
|
@carlescufi Aside from the compliance issue about the typdedef addition that I can't avoid, PR is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #39430 (Thanks @gmarull for the great initial work)
Following merge of pinctrl API (#37572), provide the STM32 implementation.
This takes place of the existing, similar but non generic STM32 implementation.
All in-tree drivers are converted, along with the peripheral configuration for each in tree boards.
Deprecation of the previous API is not addressed, to comply with deprecation timeline proposed in #39740
Replaces #39430
Important notice:
pinctrl-0andpinctrl-namesare now set as required properties (for pinctrl user devices).Main reason is to avoid DT_API cryptic error messages when not provided.
Note: Set as DNM as it includes a BK temp patch to increase workload capacity
EDIT: Compliance check reports a typdef warning, which I suggest to discard.
EDIT: 11/15:
Removed PWM driver update, due to underlying issue in PWM driver that should be taken care first and separately. Submitted #40430 to handle PWM case.EDIT: 11/23: Based on #40515 to remove need to use
PINCTRL_STORE_REGon F1 series. As a consequence, PWM driver update is back.EDIT: 11/24: Added a couple of commits to fix erroneous board descriptions that are now leading to build issues (now that pinctrl-0 and pinctrl-names are required)