cmake: Do not include zephyr_stdint.h for native POSIX archs

[stephanosio]

This commit updates the Zephyr build system such that it does not
include the zephyr_stdint.h, which tries to define Zephyr's own type
system, when compiling for the native POSIX architecture.

The native POSIX architecture compiles with the host toolchain and
headers, and there can be conflicts if we arbitrarily define our own
type system (e.g. mismatch between the types and the specifiers defined
in inttypes.h).

Note that this is not meant to be a permanent fix; instead, it is meant
to serve as a temporary workaround until we no longer need to define
our own type system.

For more details, refer to the issue #37718.

Signed-off-by: Stephanos Ioannidis [email protected]

Fixes #37718.

[cfriedt]

@nashif - also fairly trivial build-related issue. Can you ack?

[cfriedt]

@tejlmand - please have a review

[tejlmand]

shouldn't the comment above be inside the if ?

# @Intent: Enforce standard integer type correspondance to match Zephyr usage.
# (must be after compiler specific flags)

As I see it, that comment belongs with the zephyr_compile_options(...) call.

[stephanosio]

Well, that comment describes the following "code block" which includes the zephyr_compile_options inside if.

In this file, we seem to have multiple instances of the @Intent comment being placed similarly:

zephyr/CMakeLists.txt

Lines 109 to 112 in d7b5c3b

	# @Intent: Set compiler flags to detect general stack overflows across all functions
	if(CONFIG_STACK_CANARIES)
	zephyr_compile_options($<TARGET_PROPERTY:compiler,security_canaries>)
	endif()

zephyr/CMakeLists.txt

Lines 165 to 170 in d7b5c3b

	# @Intent: Obtain compiler specific flags for compiling under different ISO standards of C++
	if(CONFIG_CPLUSPLUS)
	# From kconfig choice, pick a single dialect.
	# Kconfig choice ensures only one of these CONFIG_STD_CPP* is set.
	if(CONFIG_STD_CPP98)
	set(STD_CPP_DIALECT_FLAGS $<TARGET_PROPERTY:compiler-cpp,dialect_cpp98>)

zephyr/CMakeLists.txt

Lines 282 to 286 in d7b5c3b

	# @Intent: Add cmake -DW toolchain supported warnings, if any
	if(W MATCHES "1")
	zephyr_compile_options($<$<COMPILE_LANGUAGE:C>:$<TARGET_PROPERTY:compiler,warning_dw_1>>)
	zephyr_compile_options($<$<COMPILE_LANGUAGE:CXX>:$<TARGET_PROPERTY:compiler-cpp,warning_dw_1>>)
	endif()

This is really just a style issue, so I will relocate that comment in this PR if you prefer it that way.

[tejlmand]

I see your point.
But the other examples closely follows what they are testing, like:

• general stack overflows comment follows if(CONFIG_STACK_CANARIES)
• C++ comment follows the if(CONFIG_CPLUSPLUS)
• -DW comment follows if(W MATCHES "1")

whereas this comment talks about enforcing standard integer types, so the relation from that comment to ARCH_POSIX is less obvious.

Maybe the best solution is to not move that comment, but instead update it, so that it is clear from the @Intent comment that it only applies for not native posix.

[tejlmand]

but my main reason for original comment was to be sure it was forgotten by mistake, and based on your answer it seems to be on purpose.

[tejlmand]

changes looks good, and @stephanosio already replied regarding my comment which ensures it was not an oversight.