-
Notifications
You must be signed in to change notification settings - Fork 8.2k
cmake: compiler: Add framework for disabling C++ standard includes #38476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: compiler: Add framework for disabling C++ standard includes #38476
Conversation
|
@evgeniy-paltsev @abrodkin Does ARC MWDT have something like |
cfriedt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@tejlmand - can you take a look? |
|
@nashif - this is a fairly straight-forward PR that mainly touches the build system. Are you able to ack? |
@stephanosio I guess we do similar thing for MWDT but in a slightly different way: |
tejlmand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compiler flags should simply specify flags, not decide whether they should be used or not.
This commit adds a new C++ compiler property `nostdincxx` which specifies the C++ compiler flag for excluding the C++ standard library include directory from the include paths. Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit adds the `nostdincxx` C++ compiler property for GCC, which is specified when the C++ standard library (`CONFIG_LIB_CPLUSPLUS`) is disabled. Signed-off-by: Stephanos Ioannidis <[email protected]>
The TensorFlow Lite module makes use of the features provided by the standard C++ library (e.g. `#include <functional>`), so the standard C++ library config must be enabled for it. This used to work without `CONFIG_LIB_CPLUSPLUS=y` due to the bug described in the issue zephyrproject-rtos#36644. Signed-off-by: Stephanos Ioannidis <[email protected]>
edbc846 to
4f436e7
Compare
tejlmand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. good to get things like this cleaned up.
Fixes #36644.