Skip to content

Conversation

@kontais
Copy link
Contributor

@kontais kontais commented May 2, 2017

boards/arm/stm3210c_eval/support/openocd.cfg
board/st3210c_eval.cfg -> board/stm3210c_eval.cfg


This change is Reviewable

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kontais,

Thanks for this contribution.
Your commit is blocked by CI checks.
You should add your sign-off to the commit message.
This will help CI to go fruther

@galak galak self-assigned this May 2, 2017
@kontais kontais closed this May 2, 2017
pabigot added a commit to pabigot/zephyr that referenced this pull request Nov 2, 2019
Add specific compatible to existing JEDEC SPI device.

Add a second JEDEC SPI device with a different compatible.

Demonstrates issues with checkpatch:

    -:27: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "mxicy,mx25r6435f" appears un-documented -- check ./dts/bindings/
    zephyrproject-rtos#27: FILE: boards/arm/nrf52840_pca10056/nrf52840_pca10056.dts:195:
    +  compatible = "mxicy,mx25r6435f", "jedec,spi-nor";

    -:37: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "mxicy,mx25l3233f" appears un-documented -- check ./dts/bindings/
    zephyrproject-rtos#37: FILE: boards/arm/nrf52840_pca10056/nrf52840_pca10056.dts:207:
    +  compatible = "mxicy,mx25l3233f", "jedec,spi-nor";

Demonstrates inability to relate specific to generic variant by prefix:

    #define DT_INST_0_MXICY_MX25R6435F  1
    #define DT_INST_0_JEDEC_SPI_NOR     1
    #define DT_INST_0_MXICY_MX25L3233F  1
    #define DT_INST_1_JEDEC_SPI_NOR     1

Signed-off-by: Peter Bigot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants