Add Atmel SAM0 pinctrl #35423
Add Atmel SAM0 pinctrl #35423
Conversation
nandojve
added
the
platform: Microchip SAM
nandojve
force-pushed
the
sam0_pinctrl_plus_uart
branch
from
6331721 to
ebd12fb
Compare
|
The compliance check didn't detect some Macro construction. It is a well know problem. |
nandojve
requested review from
MaureenHelm,
ioannisg,
nashif and
vanwinkeljan
as code owners
nandojve
force-pushed
the
sam0_pinctrl_plus_uart
branch
from
ebd12fb to
3820e76
Compare
|
rebase |
nandojve
force-pushed
the
sam0_pinctrl_plus_uart
branch
from
3820e76 to
849a19e
Compare
|
Hi @mnkp , I made apply some changes as requested. I implement a variable length macro to explicit assign pin to an peripheral. It allows add any other GPIO flag. It only add flexibility at pin definition. |
nandojve
force-pushed
the
sam0_pinctrl_plus_uart
branch
from
849a19e to
27c15ba
Compare
mnkp
left a comment
mnkp
left a comment
There was a problem hiding this comment.
Looks good. So, should we change soc_gpio.c to soc_port.c and change the prefix of the functions in the file?
nandojve
force-pushed
the
sam0_pinctrl_plus_uart
branch
from
27c15ba to
2c674c8
Compare
|
We could update commit message of the first commit. It still refers to |
Yes, this confirm that I need one week vacation heheh. |
nandojve
force-pushed
the
sam0_pinctrl_plus_uart
branch
from
2c674c8 to
2d0b362
Compare
|
@galak The PR looks good, we could merge it, but it requires approval from one more reviewer. |
galak
force-pushed
the
sam0_pinctrl_plus_uart
branch
from
2d0b362 to
985915a
Compare
|
Rebased on main just to make sure this still passes CI. |
Introduce soc_port common functions. The sam0 pinmux driver was refactored to use soc_port_pinmux_set common function. This create the common base to implement sam0 pinctrl functions. Signed-off-by: Gerson Fernando Budke <[email protected]>
Add Atmel sam0 MCU series pinctrl devicetree bindings and infrastructure. Signed-off-by: Gerson Fernando Budke <[email protected]>
Add Atmel sam0 sercom[uart] pinctrl bindings and implements pinctrl at driver level. It changes all sam0 boards to use new feature and remove pinmux driver dependency for sercom[uart]. The samples that require a binding were update to keep consistency and avoid errors. Signed-off-by: Gerson Fernando Budke <[email protected]>
nandojve
force-pushed
the
sam0_pinctrl_plus_uart
branch
from
985915a to
7c91f46
Compare
Sure, thank you Kumar! |
3 participants
Atmel SAM already uses pinctrl feature but SAM0 doesn't have support. This refactor pinmux driver to use a new common SoC gpio methods. It add the gpio and pinctrl devicetree bindings structures and macros.
As part of this PR sercom[uart] driver was enhanced to use pinctrl. All sercom[uart] configuration for sam0 boards were updated to use pinctrl and pinmux entries were removed. Some samples were altered to allow consistency.
Tested with SAMR21.