kernel/timeout: Fix 32 bit rollover conditions #26254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two spots where CONFIG_TIMEOUT_64BIT wasn't being correctly honored, leading to the possibility of long timeouts overflowing internally and doing weird stuff. Fixes zephyrproject-rtos#26248 Signed-off-by: Andy Ross <[email protected]>
andyross
requested review from
MaureenHelm,
andrewboie,
carlescufi,
galak and
nashif
as code owners
Member
|
Seems like we might want to backport this to 2.3.1? |
Contributor
Author
|
Good point. Yes, this is a pure bug fix against 2.3, should be backported. I forget the process :) |
andrewboie
approved these changes
Jun 17, 2020
pabigot
approved these changes
Jun 17, 2020
jhedberg
approved these changes
Jun 18, 2020
Member
|
@andyross will you send a PR against the 2.3 branch please? |
Contributor
Author
|
OK, but wasn't there some kind of automated thing that would collect and cherry pick backports? |
Member
@andyross there was, but it hasn't been working for several releases, unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two spots where CONFIG_TIMEOUT_64BIT wasn't being correctly
honored, leading to the possibility of long timeouts overflowing
internally and doing weird stuff.
Fixes #26248
Signed-off-by: Andy Ross [email protected]