net: sockets: Fix socket ctx check in usermode #26001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `z_get_fd_obj_and_vtable()` function returns NULL (no valid entry in the FD table for the socket), there is no need for further usermode checks on the `ctx` pointer, as there is nothing to invalidate in that case. Fixes zephyrproject-rtos#25990 Fixes zephyrproject-rtos#25991 Signed-off-by: Robert Lubos <[email protected]>
jukkar
approved these changes
Jun 5, 2020
carlescufi
approved these changes
Jun 5, 2020
Member
|
I can confirm that this fixes the problem reported in #25991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
z_get_fd_obj_and_vtable()function returns NULL (no valid entryin the FD table for the socket), there is no need for further usermode
checks on the
ctxpointer, as there is nothing to invalidate in thatcase.
Fixes #25990
Fixes #25991
Signed-off-by: Robert Lubos [email protected]