Skip to content

Conversation

@tbursztyka
Copy link
Contributor

@tbursztyka tbursztyka commented Mar 18, 2020

Part of #22941
Based on top of #24511

This provide a generic infrastructure for device drivers to report their status after initialization and each and every calls.

@tbursztyka tbursztyka force-pushed the device_error_report_and_mgmt branch from 2a88e90 to 16e69ac Compare March 18, 2020 19:10
@zephyrbot zephyrbot added area: API Changes to public APIs area: Kernel labels Mar 18, 2020
@zephyrbot
Copy link

zephyrbot commented Mar 18, 2020

Some checks failed. Please fix and resubmit.

checkpatch issues

-:183: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#183: FILE: include/linker/linker-defs.h:90:
+#define DEVICE_CONTEXT_SECTIONS()				\
+		__device_context_start = .;			\
+		CREATE_OBJ_LEVEL(device_context, PRE_KERNEL_1)	\
+		CREATE_OBJ_LEVEL(device_context, PRE_KERNEL_2)	\
+		CREATE_OBJ_LEVEL(device_context, POST_KERNEL)	\
+		CREATE_OBJ_LEVEL(device_context, APPLICATION)	\
+		CREATE_OBJ_LEVEL(device_context, SMP)		\
+		__device_context_end = .;			\
+

-:183: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#183: FILE: include/linker/linker-defs.h:90:
+#define DEVICE_CONTEXT_SECTIONS()				\
+		__device_context_start = .;			\
+		CREATE_OBJ_LEVEL(device_context, PRE_KERNEL_1)	\
+		CREATE_OBJ_LEVEL(device_context, PRE_KERNEL_2)	\
+		CREATE_OBJ_LEVEL(device_context, POST_KERNEL)	\
+		CREATE_OBJ_LEVEL(device_context, APPLICATION)	\
+		CREATE_OBJ_LEVEL(device_context, SMP)		\
+		__device_context_end = .;			\
+

- total: 1 errors, 1 warnings, 942 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@tbursztyka tbursztyka force-pushed the device_error_report_and_mgmt branch 3 times, most recently from b193fc9 to 11c624b Compare March 19, 2020 11:45
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Mar 19, 2020
@tbursztyka tbursztyka force-pushed the device_error_report_and_mgmt branch from 9e6c723 to 7c8f318 Compare March 23, 2020 08:24
@tbursztyka tbursztyka force-pushed the device_error_report_and_mgmt branch 3 times, most recently from 41a3ba9 to 77b2138 Compare March 27, 2020 08:15
@tbursztyka tbursztyka force-pushed the device_error_report_and_mgmt branch from 77b2138 to 538a98e Compare April 20, 2020 11:40
@tbursztyka tbursztyka changed the title [RFC][DNM] Device status reporting scheme [RFC] Device status reporting scheme Apr 20, 2020
@tbursztyka tbursztyka force-pushed the device_error_report_and_mgmt branch 9 times, most recently from c34c81f to 3968a48 Compare April 27, 2020 09:09
@tbursztyka tbursztyka force-pushed the device_error_report_and_mgmt branch 3 times, most recently from f07f516 to 27a8e37 Compare April 30, 2020 18:50
@tbursztyka tbursztyka force-pushed the device_error_report_and_mgmt branch from 27a8e37 to f8f570d Compare May 1, 2020 12:28
@github-actions github-actions bot added has-conflicts Issue/PR has conflicts with another issue/PR and removed has-conflicts Issue/PR has conflicts with another issue/PR labels Jun 29, 2020
@nashif nashif added the Stale label Sep 4, 2020
@github-actions github-actions bot closed this Sep 19, 2020
@tbursztyka tbursztyka deleted the device_error_report_and_mgmt branch April 7, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: API Changes to public APIs area: Device Management area: Kernel area: Tests Issues related to a particular existing or missing test has-conflicts Issue/PR has conflicts with another issue/PR Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants