Skip to content

Conversation

@pabigot
Copy link
Contributor

@pabigot pabigot commented Jan 27, 2020

Document and assign write-protect signal as active low, and use the
active-sensitive API to control it.

Signed-off-by: Peter Bigot [email protected]

Document and assign write-protect signal as active low, and use the
active-sensitive API to control it.

Signed-off-by: Peter Bigot <[email protected]>
@zephyrbot
Copy link

All checks passed.

checkpatch (informational only, not a failure)

-:59: WARNING:LONG_LINE: line over 80 characters
#59: FILE: drivers/eeprom/eeprom_at2x.c:520:
+					 GPIO_OUTPUT_ACTIVE | config->wp_gpio_flags);

- total: 0 errors, 1 warnings, 150 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@pabigot pabigot requested a review from MaureenHelm January 27, 2020 15:26
#define DT_INST_0_ATMEL_AT24_WP_GPIOS_CONTROLLER NULL
#define DT_INST_0_ATMEL_AT24_WP_GPIOS_PIN 0
#define DT_INST_0_ATMEL_AT24_WP_GPIOS_FLAGS 0
#define DT_INST_0_ATMEL_AT24_WP_GPIOS_FLAGS GPIO_ACTIVE_LOW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just default values in case no WP pin is set in DTS. They can remain as 0 or GPIO_ACTIVE_LOW. Their value is not used. It is just to satisfy the C macro for generating the device instance.

@henrikbrixandersen henrikbrixandersen self-requested a review January 27, 2020 19:39
@MaureenHelm MaureenHelm merged commit af6313b into zephyrproject-rtos:topic-gpio Jan 27, 2020
@pabigot pabigot deleted the gpio/at2x branch February 1, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants