[TOPIC-GPIO]: Convert LMP90xxx ADC and GPIO drivers to new GPIO API #22212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikbrixandersen
requested review from
MaureenHelm,
anangl,
carlescufi,
erwango,
galak and
nashif
as code owners
zephyrbot
added
area: ADC
pabigot
approved these changes
Jan 27, 2020
Contributor
pabigot
left a comment
pabigot
left a comment
There was a problem hiding this comment.
This seems ok. Have you tested gpio_basic_api and gpio_api_1pin?
henrikbrixandersen
force-pushed
the
topic-gpio-lmp90xxx
branch
2 times, most recently
from
f748d42 to
ba7d093
Compare
Add ngpios device tree property to the GPIO controller node of the LMP90100 EVB shield. Signed-off-by: Henrik Brix Andersen <[email protected]>
Update the TI LMP90xxx GPIO driver to the new GPIO API. Signed-off-by: Henrik Brix Andersen <[email protected]>
Update the DRDYB pin interrupt handling code of the TI LMP90xxx ADC driver to use the new GPIO API. Signed-off-by: Henrik Brix Andersen <[email protected]>
henrikbrixandersen
force-pushed
the
topic-gpio-lmp90xxx
branch
from
ba7d093 to
2ee183d
Compare
Member
Author
@pabigot Yes. Both pass. |
mnkp
reviewed
Jan 27, 2020
carlescufi
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert both the GPIO controller part and the GPIO consumer (interrupt consumer) part of the TI LMP90xxx drivers to use the new GPIO API.