[topic-gpio] drivers: display: mb_display: Convert to the new GPIO API #22157
Conversation
Convert to the new GPIO API, use raw access since this is a low-level GPIO-based driver. Signed-off-by: Carles Cufi <[email protected]>
| /* Set the column pins to their correct values */ | ||
| for (pin = LED_COL1_GPIO_PIN; pin <= LED_COL9_GPIO_PIN; pin++) { | ||
| gpio_pin_write(disp->dev, pin, !!(val & BIT(pin))); | ||
| gpio_pin_set_raw(disp->dev, pin, !!(val & BIT(pin))); |
There was a problem hiding this comment.
I did not want to change the original !!(), leaving it to @jhedberg if he prefers to use a simple & instead.
There was a problem hiding this comment.
Aren't the correct values of the last parameter 0 and 1? That's what the !! is there for.
There was a problem hiding this comment.
The way the function is documented x & mask should work ("Writing any value other than 0 will set it to a high physical level.") Either !!(x & mask) or (x & mask) != 0 are good for clarity of intention. Sometimes people are confused by !!x though I personally like it (except where MISRA essential type requires a "boolean" expression).
|
Tested on the micro:bit, using the display sample. |
| /* Set the column pins to their correct values */ | ||
| for (pin = LED_COL1_GPIO_PIN; pin <= LED_COL9_GPIO_PIN; pin++) { | ||
| gpio_pin_write(disp->dev, pin, !!(val & BIT(pin))); | ||
| gpio_pin_set_raw(disp->dev, pin, !!(val & BIT(pin))); |
There was a problem hiding this comment.
The way the function is documented x & mask should work ("Writing any value other than 0 will set it to a high physical level.") Either !!(x & mask) or (x & mask) != 0 are good for clarity of intention. Sometimes people are confused by !!x though I personally like it (except where MISRA essential type requires a "boolean" expression).
carlescufi
changed the title
6 participants
Convert to the new GPIO API, use raw access since this is a low-level
GPIO-based driver.
Signed-off-by: Carles Cufi [email protected]