[topic-gpio] samples: reel_board: mesh_badge: Convert to the new GPIO API

[carlescufi]

See commit messages.

[carlescufi]

Partially tested on the reel_board. @jhedberg could you please test it a bit more to make sure I haven't missed anything?

[zephyrbot]

All checks are passing now.

checkpatch (informational only, not a failure)

-:191: WARNING:LONG_LINE: line over 80 characters
#191: FILE: samples/boards/reel_board/mesh_badge/src/reel_board.c:70:
+	{ .name = DT_ALIAS_LED0_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED0_GPIOS_PIN,

-:193: WARNING:LONG_LINE: line over 80 characters
#193: FILE: samples/boards/reel_board/mesh_badge/src/reel_board.c:72:
+	{ .name = DT_ALIAS_LED1_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED1_GPIOS_PIN,

-:195: WARNING:LONG_LINE: line over 80 characters
#195: FILE: samples/boards/reel_board/mesh_badge/src/reel_board.c:74:
+	{ .name = DT_ALIAS_LED2_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED2_GPIOS_PIN,

- total: 0 errors, 3 warnings, 233 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

[anangl]

It should be GPIO_INT_EDGE_BOTH, see the definition of EDGE, which is no longer needed BTW.

[carlescufi]

Very well spotted. Fixed.

[jhedberg]

@jfischer-phytec-iot you might be interested to take a look as well

[pabigot]

Only required change is handling an error return from gpio_pin_get(), which can be treated as "not pressed". Others are commentary.

[pabigot]

gpio_pin_t would save some space.

[carlescufi]

Indeed, changed.

[pabigot]

You could just do DT_ALIAS_LED0_GPIOS which expands to the controller name, pin, and flags in a single initializer expression. Though without a pre-defined standard structure synchronized to generation of that expression it's technically more future-proof to spelling out each element.

[carlescufi]

Oh, thanks for letting me know of this DT-generated macro. As you yourself mention, since this uses designated initializers I'd rather not change it at this point.

[pabigot]

Note gpio_pin_get can return a negative value to indicate a failure to read a value. There's also an essential type error here. gpio_pin_get(...) > 0 would be better.

[carlescufi]

Agreed, fixed.