[TOPIC-GPIO] drivers: enc424j600/enc28j60: convert to new GPIO API #22130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert ENC424J600 controller driver to new GPIO API. Signed-off-by: Johann Fischer <[email protected]>
Convert ENC28J60 controller driver to new GPIO API. Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
requested review from
erwango,
galak,
jukkar,
pfalcon and
tbursztyka
as code owners
jukkar
approved these changes
Jan 23, 2020
tbursztyka
reviewed
Jan 24, 2020
| } | ||
| gpio_pin_interrupt_configure(context->gpio, | ||
| config->gpio_pin, | ||
| GPIO_INT_EDGE_TO_ACTIVE); |
Contributor
There was a problem hiding this comment.
isn't GPIO_INT_ENABLE missing?
Contributor
Author
There was a problem hiding this comment.
GPIO_INT_ENABLE is a part of GPIO_INT_EDGE_TO_ACTIVE macro.
Contributor
There was a problem hiding this comment.
ok, the documentation is a bit misleading
Member
There was a problem hiding this comment.
GPIO_INT_EDGE_TO_ACTIVE is a convenience macro targeted at users of the GPIO API. GPIO_INT_ENABLE is a macro targeted at the GPIO driver developers. In the doxygen generated documentation only convenience flags will be visible. This is fairly popular convention. Nevertheless, if someone has an idea how this can be improved it's not too late.
carlescufi
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drivers: enc424j600/enc28j60: convert to new GPIO API