[topic-gpio] Convert GPIO mesh on/off samples to the new GPIO API #22129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Vikrant8051 can you please review and test? |
anangl
approved these changes
Jan 23, 2020
Contributor
|
Ok. I will test |
carlescufi
force-pushed
the
on-off-mesh-gpio-sample
branch
from
5e630fe to
fd35c41
Compare
pabigot
approved these changes
Jan 24, 2020
mnkp
approved these changes
Jan 24, 2020
Member
There was a problem hiding this comment.
We could write it as vnd_user_data.current == STATE_ON ? 1 : 0 to be Misra-C compliant. A few more gpio_pin_set calls may need to be updated. Non blocking.
MaureenHelm
reviewed
Jan 25, 2020
Member
There was a problem hiding this comment.
are you missing calls to gpio_pin_interrupt_configure for sw0 through sw3?
Member
Author
There was a problem hiding this comment.
You are indeed right, fixed.
carlescufi
force-pushed
the
on-off-mesh-gpio-sample
branch
from
fd35c41 to
3ffe533
Compare
Member
Author
|
@MaureenHelm this should be ready now |
MaureenHelm
approved these changes
Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on nrf52840_pca10056