[TOPIC-GPIO] drivers: sensor: bma280: convert to new GPIO API #22104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Devicetree
area: Sensors
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
pabigot
changed the title
anangl
reviewed
Jan 28, 2020
pabigot
force-pushed
the
gpio/bma280
branch
2 times, most recently
from
46f3efe to
24dc1e7
Compare
anangl
approved these changes
Jan 28, 2020
Contributor
Author
|
Shippable failed on qemu_x86_64:samples/userspace/shared_mem/sample.kernel.memory_protection.shared_mem see comments in #21317. This should not block merge. |
MaureenHelm
reviewed
Jan 28, 2020
Member
There was a problem hiding this comment.
why are you passing in the DT flags here?
Contributor
Author
There was a problem hiding this comment.
Probably because whatever sample I coped that boilerplate from did that. I'll look through the existing conversions for that error when I do the other conversions. Fixed here.
Use the new pin and interrupt configuration API. NOTE: Because hardware is not available this has been build-tested only. Signed-off-by: Peter Bigot <[email protected]>
MaureenHelm
approved these changes
Jan 28, 2020
mnkp
approved these changes
Jan 28, 2020
carlescufi
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new pin and interrupt configuration API.
NOTE: Because hardware is not available this has been build-tested only.
NOTE: This PR includes #22103 along with a dummy sample used for testing. The only commit that should be merged is the one titled: "drivers: sensor: bma280: convert to new GPIO API". The PR will be marked DNM until the topic branch is rebased on a master that includes #22103.