[topic-gpio] samples: led_apa102c_bitbang: Convert to new GPIO API #22099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlescufi
changed the title
pabigot
reviewed
Jan 22, 2020
Contributor
There was a problem hiding this comment.
There's really no reason why that parameter needs to be in parentheses, but changing it isn't necessary.
Member
Author
|
Untested, I don't have the hardware. |
pabigot
approved these changes
Jan 22, 2020
Contributor
pabigot
left a comment
pabigot
left a comment
There was a problem hiding this comment.
Possible cleanups but this should be fine.
Contributor
There was a problem hiding this comment.
MISRA-inclined folks would prefer this to change to (rgb & 0x80000000U) != 0 or (better) (rgb & BIT(31)) != 0.
Member
Author
There was a problem hiding this comment.
Why not, since we are touching this file. Fixed, thanks.
Conver to the new GPIO API, using raw access since there is no DT definitions for this particular usage of the pins. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
force-pushed
the
led_apa102c_bitbang-gpio-sample
branch
from
8caebb3 to
e0c635c
Compare
Clean the expression so that it uses the BIT() macro and doesn't abuse the not (!) operator. Signed-off-by: Carles Cufi <[email protected]>
mnkp
approved these changes
Jan 22, 2020
anangl
approved these changes
Jan 23, 2020
MaureenHelm
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conver to the new GPIO API, using raw access since there is no DT
definitions for this particular usage of the pins.
Signed-off-by: Carles Cufi [email protected]