Skip to content

Conversation

@carlescufi
Copy link
Member

Convert to the new API, using raw access since there is no Device-Tree
definitions for this particular sample.

Signed-off-by: Carles Cufi [email protected]

Convert to the new API, using raw access since there is no Device-Tree
definitions for this particular sample.

Signed-off-by: Carles Cufi <[email protected]>
@carlescufi
Copy link
Member Author

Untested, I don't have the hardware.

@zephyrbot
Copy link

All checks passed.

checkpatch (informational only, not a failure)

-:10: WARNING:LONG_LINE: line over 80 characters
#10: FILE: samples/drivers/lcd_hd44780/src/main.c:143:
+		if (gpio_pin_set_raw((dev), (pin), (bit))) {			\

- total: 0 errors, 1 warnings, 34 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@carlescufi carlescufi changed the title samples: lcd_hd44780: Convert to new GPIO API [topic-gpio] samples: lcd_hd44780: Convert to new GPIO API Jan 22, 2020
@MaureenHelm MaureenHelm merged commit 415e480 into zephyrproject-rtos:topic-gpio Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants