[topic-gpio] samples: net: lwm2m_client: Convert to new GPIO API #22092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlescufi
requested review from
MaureenHelm,
anangl,
mnkp,
pabigot and
rlubos
Member
Author
|
Tested on nrf52840_pca10056 by inserting a small loop that toggles the pin to avoid having to set up a full LWM2M server. |
Convert the sample to use the new API and its features. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
force-pushed
the
lwm2m-gpio-sample
branch
from
cf3b665 to
dc87add
Compare
carlescufi
changed the title
pabigot
approved these changes
Jan 22, 2020
|
|
||
| ret = gpio_pin_write(led_dev, LED_GPIO_PIN, 0); | ||
| ret = gpio_pin_configure(led_dev, LED_GPIO_PIN, LED_GPIO_FLAGS | | ||
| GPIO_OUTPUT_INACTIVE); |
Contributor
There was a problem hiding this comment.
As a style thing (which we do not define) I find it easier to understand when split at the comma rather than within the argument expression:
ret = gpio_pin_configure(led_dev, LED_GPIO_PIN,
LED_GPIO_FLAGS | GPIO_OUTPUT_INACTIVE);
Member
Author
There was a problem hiding this comment.
I actually prefer the style where things are split to max line length and then at the bitwise or logical operator boundary myself.
MaureenHelm
approved these changes
Jan 22, 2020
anangl
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the sample to use the new API and its features.
Signed-off-by: Carles Cufi [email protected]