Skip to content

Conversation

@pabigot
Copy link
Contributor

@pabigot pabigot commented Jan 21, 2020

Update devicetree sources and bindings, switch to new GPIO API. Use
devicetree property name to identify interrupt signal.

Signed-off-by: Peter Bigot [email protected]

Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zephyrbot
Copy link

All checks passed.

checkpatch (informational only, not a failure)

-:69: WARNING:LONG_LINE: line over 80 characters
#69: FILE: drivers/sensor/ccs811/ccs811.c:482:
+	drv_data->irq_gpio = device_get_binding(DT_INST_0_AMS_CCS811_IRQ_GPIOS_CONTROLLER);

- total: 0 errors, 1 warnings, 297 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Update devicetree sources and bindings, switch to new GPIO API.  Use
devicetree property name to identify interrupt signal.

Signed-off-by: Peter Bigot <[email protected]>
@MaureenHelm MaureenHelm requested a review from mnkp January 22, 2020 12:36
@alexanderwachter
Copy link
Member

I wonder why I'm always triggered as a code-owner on changes for ccs811.

@alexanderwachter alexanderwachter removed their request for review January 22, 2020 16:28
@pabigot
Copy link
Contributor Author

pabigot commented Jan 22, 2020

@alexanderwachter This would do it:

/dts/bindings/sensor/ams*                 @alexanderwachter

@alexanderwachter
Copy link
Member

That might be :-). Git blame says anas added this line. Maybe we need to change that. I don't even have this particular sensor. (Even though this company is about 20km away from where I live :-) )

@pabigot pabigot changed the title sensors: ccs811: update to new API [TOPIC-GPIO] sensors: ccs811: update to new API Jan 23, 2020
@carlescufi carlescufi merged commit 6504ff7 into zephyrproject-rtos:topic-gpio Jan 24, 2020
@pabigot pabigot deleted the gpio/ccs811 branch January 25, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants