[TOPIC-GPIO] tests: intel_s1000_crb: update to new GPIO API #21983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
the
area: Tests
pabigot
approved these changes
Jan 17, 2020
mnkp
approved these changes
Jan 17, 2020
Member
mnkp
left a comment
mnkp
left a comment
There was a problem hiding this comment.
One minor comment, however IMHO this PR can be also merged as is.
Member
There was a problem hiding this comment.
Since this testcase is dedicated to the specific SoC and we know that gpio_pin_get function implemented by gpio_dw driver always returns 0 (as most of the drivers which control on chip GPIO hardware module) from my perspective it would be OK not to do error handling.
MaureenHelm
requested changes
Jan 20, 2020
Update the intel_s1000_crb test app: () Update configuration calls to use new flags. () Separate pin configuration into setting it to input, and setting the pin for interrupt. () Use gpio_pin_get/set() instead of gpio_pin_read/write(). Signed-off-by: Daniel Leung <[email protected]>
dcpleung
force-pushed
the
gpio_intel_s1000_crb_api_update
branch
from
2344284 to
1838cc8
Compare
MaureenHelm
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the intel_s1000_crb test app:
() Update configuration calls to use new flags.
() Separate pin configuration into setting it to input, and
setting the pin for interrupt.
() Use gpio_pin_get/set() instead of gpio_pin_read/write().
Signed-off-by: Daniel Leung [email protected]