[TOPIC-GPIO] disk: Convert sdhc spi driver to new gpio api #21918
Conversation
MaureenHelm
changed the title
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
Converts the sdhc spi driver to the new gpio api. Updates device trees for the olimexino_stm32 and nrf52840_blip boards to set appropriate active high/low polarity for the spi chip select pin. Signed-off-by: Maureen Helm <[email protected]>
|
LGTM, but wait for one of @pabigot @henrikbrixandersen @ydamigos to test on HW. |
|
I've found a board that seems to work on master, after I resolve a few idiosyncrasies I'll test this. |
pabigot
left a comment
pabigot
left a comment
There was a problem hiding this comment.
samples/subsys/fs/fat_fs needs a larger stack size to run, but that's unrelated to this. I've verified with nrf51_ble400.
I see this reveals another assumption in devicetree: that SPI chip select GPIOs are always active high so it's ok to specify that in the bus node.
I would update the pin storage to use the smaller data type, but that's not being done consistently in the conversion process so it's fine as is.
| struct device *spi; | ||
| struct spi_config cfg; | ||
| struct device *cs; | ||
| u32_t pin; |
There was a problem hiding this comment.
This could switch to gpio_pin_t and save some space.
ydamigos
left a comment
ydamigos
left a comment
There was a problem hiding this comment.
Tested samples/subsys/fs/fat_fs on olimexino_stm32 and it works fine.
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Tested on yet-to-be-submitted shield definition for Adafruit Data Logger Shield (and frdm-k64f).
8 participants
Converts the sdhc spi driver to the new gpio api. Updates device trees
for the olimexino_stm32 and nrf52840_blip boards to set appropriate
active high/low polarity for the spi chip select pin.
Signed-off-by: Maureen Helm [email protected]
@pabigot @henrikbrixandersen @ydamigos Will you please test this patch? I do not have the hardware, so I can only verify that it builds.