Skip to content

[TOPIC-GPIO] drivers: ssd1306: convert to new GPIO API #21687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

[TOPIC-GPIO] drivers: ssd1306: convert to new GPIO API #21687

merged 1 commit into from
Jan 24, 2020

Conversation

@jfischer-no
Copy link
Contributor

@jfischer-no jfischer-no commented Jan 3, 2020

Convert SSD1306 sensor driver to new GPIO API.

TODO: shield overlays, but first the gpio branch has to be rebased on master

@jfischer-no jfischer-no changed the title drivers: ssd1306: convert to new GPIO API [TOPIC-GPIO] drivers: ssd1306: convert to new GPIO API Jan 3, 2020
@carlescufi carlescufi mentioned this pull request Jan 3, 2020
Closed
@zephyrbot
Copy link

zephyrbot commented Jan 3, 2020 •
edited
Loading

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

vanwinkeljan
vanwinkeljan reviewed Jan 4, 2020
View reviewed changes
drivers/display/ssd1306.c Outdated
Copy link
Member

@vanwinkeljan vanwinkeljan Jan 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that polarity will be passed by DT_INST_0_SOLOMON_SSD1306FB_RESET_GPIOS_FLAGS?

Copy link
Contributor Author

@jfischer-no jfischer-no Jan 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did not fixed it in shield overlays because gpio bruch is outdated and has conflicts with master.

@jfischer-no jfischer-no added the DNM This PR should not be merged (Do Not Merge) label Jan 4, 2020
@carlescufi carlescufi removed the DNM This PR should not be merged (Do Not Merge) label Jan 21, 2020
mnkp
mnkp requested changes Jan 21, 2020
View reviewed changes
@jfischer-no jfischer-no reopened this Jan 22, 2020
@jfischer-no
drivers: ssd1306: convert to new GPIO API
b1f4dc5 
Convert SSD1306 sensor driver to new GPIO API.

Signed-off-by: Johann Fischer <[email protected]>
@carlescufi carlescufi merged commit 1c27ee0 into zephyrproject-rtos:topic-gpio Jan 24, 2020
@vanwinkeljan
Copy link
Member

vanwinkeljan commented Jan 24, 2020

@jfischer-phytec-iot should the shield overlays not have been updated before merging this change?

@jfischer-no
Copy link
Contributor Author

jfischer-no commented Jan 24, 2020

@jfischer-phytec-iot should the shield overlays not have been updated before merging this change?

@vanwinkeljan We do not have any with gpio in the tree for this one :-)

@vanwinkeljan
Copy link
Member

vanwinkeljan commented Jan 24, 2020

sorry for not reviewing noticed the TODO in the first comment and thought there was still some work left

@jfischer-no jfischer-no deleted the gpio-ssd1306 branch October 10, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlescufi carlescufi carlescufi approved these changes

@mnkp mnkp mnkp approved these changes

@pabigot pabigot Awaiting requested review from pabigot

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@galak galak Awaiting requested review from galak

+1 more reviewer

@vanwinkeljan vanwinkeljan vanwinkeljan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: Devicetree area: Display area: Drivers area: GPIO

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jfischer-no @zephyrbot @vanwinkeljan @carlescufi @mnkp