Skip to content

[TOPIC-GPIO] drivers: ti_hdc: convert to new GPIO API #21543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020
Merged

[TOPIC-GPIO] drivers: ti_hdc: convert to new GPIO API #21543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boards/arm/reel_board/dts/reel_board.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ arduino_i2c: &i2c0 {
compatible = "ti,hdc","ti,hdc1010";
reg = <0x43>;
label = "HDC1010";
drdy-gpios = <&gpio0 22 GPIO_PUD_PULL_UP>;
drdy-gpios = <&gpio0 22 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
};

apds9960@39 {
Expand Down
18 changes: 11 additions & 7 deletions drivers/sensor/ti_hdc/ti_hdc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ static void ti_hdc_gpio_callback(struct device *dev,

ARG_UNUSED(pins);

gpio_pin_disable_callback(dev, DT_INST_0_TI_HDC_DRDY_GPIOS_PIN);
gpio_pin_interrupt_configure(drv_data->gpio,
DT_INST_0_TI_HDC_DRDY_GPIOS_PIN,
GPIO_INT_DISABLE);
k_sem_give(&drv_data->data_sem);
}
#endif
Expand All @@ -39,7 +41,9 @@ static int ti_hdc_sample_fetch(struct device *dev, enum sensor_channel chan)
__ASSERT_NO_MSG(chan == SENSOR_CHAN_ALL);

#if defined(DT_INST_0_TI_HDC_DRDY_GPIOS_CONTROLLER)
gpio_pin_enable_callback(drv_data->gpio, DT_INST_0_TI_HDC_DRDY_GPIOS_PIN);
gpio_pin_interrupt_configure(drv_data->gpio,
DT_INST_0_TI_HDC_DRDY_GPIOS_PIN,
GPIO_INT_EDGE_TO_ACTIVE);
#endif

buf[0] = TI_HDC_REG_TEMP;
Expand Down Expand Up @@ -150,11 +154,7 @@ static int ti_hdc_init(struct device *dev)
}

gpio_pin_configure(drv_data->gpio, DT_INST_0_TI_HDC_DRDY_GPIOS_PIN,
GPIO_DIR_IN | GPIO_INT | GPIO_INT_EDGE |
#if defined(DT_INST_0_TI_HDC_DRDY_GPIOS_FLAGS)
DT_INST_0_TI_HDC_DRDY_GPIOS_FLAGS |
#endif
GPIO_INT_ACTIVE_LOW | GPIO_INT_DEBOUNCE);
GPIO_INPUT | DT_INST_0_TI_HDC_DRDY_GPIOS_FLAGS);

gpio_init_callback(&drv_data->gpio_cb,
ti_hdc_gpio_callback,
Expand All @@ -164,6 +164,10 @@ static int ti_hdc_init(struct device *dev)
LOG_DBG("Failed to set GPIO callback");
return -EIO;
}

gpio_pin_interrupt_configure(drv_data->gpio,
DT_INST_0_TI_HDC_DRDY_GPIOS_PIN,
GPIO_INT_EDGE_TO_ACTIVE);
#endif

LOG_INF("Initialized device successfully");
Expand Down
5 changes: 5 additions & 0 deletions dts/bindings/sensor/ti,hdc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,8 @@ properties:
drdy-gpios:
type: phandle-array
required: false
description: Data ready pin.

The DRDYn pin of HDC sensor is open-drain, active low.
If connected directly the MCU pin should be configured
as pull-up, active low.