samples: sensors: isl29035: add sample #21434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
force-pushed
the
nordic/20191216d
branch
from
cdaacf5 to
1f8b51a
Compare
dbkinder
suggested changes
Dec 17, 2019
Contributor
dbkinder
left a comment
dbkinder
left a comment
There was a problem hiding this comment.
A couple of doc tweaks, then LGTM.
samples/sensor/isl29035/README.rst
Outdated
samples/sensor/isl29035/README.rst
Outdated
Contributor
There was a problem hiding this comment.
change to resets the 10-second window
Contributor
Author
There was a problem hiding this comment.
It's actually the intensity range window, not the time window. Updated, along with the delete requested above. Please re-check; thanks.
Add a sample to demonstrate and test the Renesas/Intersil ISL29035 light sensor driver. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
nordic/20191216d
branch
from
1f8b51a to
de7fc8d
Compare
dbkinder
approved these changes
Dec 18, 2019
Contributor
dbkinder
left a comment
dbkinder
left a comment
There was a problem hiding this comment.
+1 for doc changes, thanks!
MaureenHelm
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a sample to demonstrate and test the Renesas/Intersil ISL29035 light sensor driver.