[TOPIC-GPIO]: sensors: mcp9808: update to new API #21427
Conversation
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
|
Not ready for review, I forgot that |
pabigot
force-pushed
the
gpio/20191216c
branch
from
8c3cda2 to
3fd8c39
Compare
Very non-trivial. Reworked for master in #21547 which made the conversion trivial. |
pabigot
force-pushed
the
gpio/20191216c
branch
from
3fd8c39 to
733d8c3
Compare
mnkp
left a comment
mnkp
left a comment
There was a problem hiding this comment.
I reviewed "drivers: sensor: mcp9808: update to new GPIO API" commit only.
|
I believe it is too early to remove DNM label since "drivers: sensor: mcp9808: fix various problems and improve test" commit hasn't been merged on master yet. |
samples/sensor/mcp9808/README.rst
Outdated
There was a problem hiding this comment.
let's change this to:
maintains a |plusminus| 2 |deg| C window ...
samples/sensor/mcp9808/README.rst
Outdated
There was a problem hiding this comment.
These three lines should be
trigger fired 1, temp 15.9375 Cel
Alert on temp outside [15437, 16437] mCel
Trigger set got 0
There was a problem hiding this comment.
I'll implement them in #21547; this PR is dependent on that one.
These three lines are exactly as produced by the sample, because the output is interleaved because two separate threads produce it. I can add a comment explaining this, but it would be misleading to "fix" the output when it doesn't represent what the user will see.
There was a problem hiding this comment.
Sigh. Yes, please explain the mangled output because separate threads are writing it (unless there's an API available that prevents interleaving output). Otherwise, it looks like a misspelling.
pabigot
force-pushed
the
gpio/20191216c
branch
from
733d8c3 to
ec8a301
Compare
|
DNM until #21547 is merged to master and topic-gpio is rebased on that. |
Since this was converted to the setup/handle/process idiom in master the conversion is straightforward. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
gpio/20191216c
branch
from
ec8a301 to
3c976b8
Compare
MaureenHelm
dismissed
dbkinder’s stale review
doc changes no longer part of this PR
5 participants
This PR includes two patches from master, plus #21547, that should disappear when the topic branch is rebased. Only the last commit in the series is specific to the new API.