[TOPIC-GPIO] drivers: sensor: Convert fxos8700 to new gpio api #21311
Conversation
pabigot
left a comment
pabigot
left a comment
There was a problem hiding this comment.
I don't see anything that really concerns me here. I would like to see the bindings yaml updated with a description of each signal, specifically active level. st,hts221.yaml has the prototypical text. That's the only blocking change from me.
Sensor drivers are not consistent in when and how interrupts are managed. For example, I suspect this driver could misbehave if the sensor signaled an event between the point where a previous interrupt was cleared and the interrupts were re-enabled. That's not a new concern, and it might not be relevant for this sensor, so seems out of scope for this conversion. For reference #20017 (comment) discusses the problem and describes an idiomatic solution implemented in hts221.
drivers/sensor/fxos8700/fxos8700.h
Outdated
There was a problem hiding this comment.
With a rebase this can become gpio_devicetree_flags_t which will pack better. Also reset_flags below.
Converts the fxos8700 sensor driver to the new gpio api. Updates device trees for all boards with this sensor to active low gpio interrupts by default. Tested on frdm_k64f and rv32m1_vega_ri5cy boards. The latter verifies that the reset output works correctly. Signed-off-by: Maureen Helm <[email protected]>
jfischer-no
left a comment
jfischer-no
left a comment
There was a problem hiding this comment.
tested on reel board
6 participants
Converts the fxos8700 sensor driver to the new gpio api. Updates device
trees for all boards with this sensor to active low gpio interrupts by
default (one less i2c transaction than active high), but the driver now
supports active high gpio interrupts if needed.
Tested on frdm_k64f and rv32m1_vega_ri5cy boards. The latter verifies
that the reset output works correctly.
Signed-off-by: Maureen Helm [email protected]